Map time integrator for convergence tests #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
approved these changes
Oct 30, 2024
Collaborator
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
@cbegeman, sorry for not getting to this sooner. I like your solution. I agree, we can generalize it beyond convergence in the future as needed. If you can rebase to hopefully let CI succeed, feel free to merge as soon as it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a mapping between MPAS-O and Omega time integrator namelist options in the convergence forward step rather than in the manufactured solution test case. As more non-convergence Omega tests and supported Omega time integration schemes are added, this mapping may be moved.