Skip to content

Support the Omega time coordinate #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 23, 2024
Merged

Support the Omega time coordinate #249

merged 4 commits into from
Dec 23, 2024

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Nov 28, 2024 •
edited
Loading

This merge fixes the manufactured solution analysis task in Omega by using the time coordinate instead of the MPAS-Ocean xtime variable.

It also attempts to use time in the viz step but testing is currently inhibited by #248

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added ocean Related to the ocean component Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Nov 28, 2024
@xylar xylar self-assigned this Nov 28, 2024
@xylar
Copy link
Collaborator Author

xylar commented Nov 28, 2024

Needs #231 and E3SM-Project/Omega#169

@xylar
Copy link
Collaborator Author

xylar commented Nov 28, 2024

I was able to run the manufactured solution test case successfully, including analysis. However, without E3SM-Project/Omega#170, it doesn't behave correctly (as expected) and the convergence rate is terrible.

@xylar
Copy link
Collaborator Author

xylar commented Nov 29, 2024

Viz should be tested after #250 is merged and this gets rebased.

@xylar xylar force-pushed the support-omega-time-coord branch from 51be5cb to bdd5ae4 Compare December 4, 2024 14:05
@xylar xylar mentioned this pull request Dec 4, 2024
Merged
6 tasks
@xylar xylar force-pushed the support-omega-time-coord branch 3 times, most recently from b64edf8 to c43e7df Compare December 4, 2024 19:01
@xylar xylar mentioned this pull request Dec 4, 2024
Merged
3 tasks
@xylar
Copy link
Collaborator Author

xylar commented Dec 4, 2024 •
edited
Loading

Testing

Tested with manufactured solution on Chrysalis, see #231 (comment)

@xylar xylar added Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished and removed Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Dec 16, 2024
cbegeman
cbegeman reviewed Dec 20, 2024
View reviewed changes
cbegeman
cbegeman reviewed Dec 20, 2024
View reviewed changes
cbegeman
cbegeman approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a minor change, which you can take or leave. I successfully ran the analysis step of manufactured_solution with this change.

xylar added 3 commits December 22, 2024 10:49
@xylar
Support Omega time in convergence analysis step
a29e734
@xylar
Support Omega time in mfd_sln viz step
e4c4394
@xylar
Reorganize mpas.time based on @cbegeman's suggestions
7f79974 
This merge adds a function `time_since_start()` that converts
`xtime` to seconds since the beginning of the simulation.
@xylar xylar force-pushed the support-omega-time-coord branch from 93e8fc4 to 7f79974 Compare December 22, 2024 16:50
@xylar xylar marked this pull request as ready for review December 22, 2024 16:51
@xylar
Copy link
Collaborator Author

xylar commented Dec 23, 2024

Retested with suggested changes using Omega on Chrysalis to run the manufactured_solution test case.

@xylar xylar merged commit 265bb55 into E3SM-Project:main Dec 23, 2024
5 checks passed
@xylar xylar deleted the support-omega-time-coord branch December 23, 2024 09:05
@xylar
Copy link
Collaborator Author

xylar commented Dec 23, 2024

Thank you, @cbegeman, for the review including the excellent suggested changes, which I have made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbegeman cbegeman cbegeman approved these changes

Assignees

@xylar xylar

Labels

ocean Related to the ocean component Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xylar @cbegeman