Fix planar plots with log norm #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
bug
Collaborator
Author
TestingI was able to run the |
Collaborator
Author
|
@andrewdnolan, could you take a quick look at this? A review by code inspection should be sufficient. |
xylar
commented
Mar 12, 2025
6 tasks
andrewdnolan
requested changes
Mar 12, 2025
We can't pass `vmin` and `vmax` along with `norm` that also tried to define the min and max: ``` ValueError: Passing a Normalize instance simultaneously with vmin/vmax is not supported. Please pass vmin/vmax directly to the norm when creating it. ``` This merge also drops an attempt to keep `vmin` positive for log norm, instead requiring the calling code to set reasonable bounds for log plots.
Collaborator
Author
|
@andrewdnolan, could you have another look? |
andrewdnolan
approved these changes
Mar 12, 2025
Collaborator
andrewdnolan
left a comment
andrewdnolan
left a comment
There was a problem hiding this comment.
Looks good. This seems like the cleanest solution.
Thanks for catching this!
Collaborator
Author
|
I verified that |
Collaborator
Author
|
Thanks @andrewdnolan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't pass
vminandvmaxalong withnormthat also tried to define the min and max:This merge also drops an attempt to keep
vminpositive for log norm, instead requiring the calling code to set reasonable bounds for log plots.Checklist
Testingcomment in the PR documents testing used to verify the changes