Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Jun 16, 2025

This merge adds e3sm/init/<mesh>/topo/cull tasks for each supported base mesh, and associated steps for masking and then culling the base meshes to land and ocean regions (the latter with and without Antarctic ice-shelf cavities). A config option also allows a user to retain the grounded ice below Antarctica as part of the ocean domain (a need for future work on MALI coupling to MPAS-Ocean in the FAnSSIE project).

This work requires a bug fix in mpas_tools 1.2.2 (which requires updating polaris to v0.8.0-alpha.3) that fixes writing CDF5 format files with logging enabled.

The documentation has been reorganized to break out into separate documents the descriptions or combining and remapping topography, and then culling the base mesh based on this topography.

This merge also fixes a few issues discovered with e3sm/init/<mesh>/topo/remap tasks and steps discovered in this development.

Checklist

  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes
  • New tests have been added to a test suite

@xylar xylar self-assigned this Jun 16, 2025
@xylar xylar added enhancement New feature or request e3sm/init Related to the e3sm/init component labels Jun 16, 2025
@xylar
Copy link
Collaborator Author

xylar commented Jun 16, 2025

Testing

I successfully ran all the topo/cull tasks on Chrysalis:

/lcrc/group/e3sm/ac.xylar/polaris_0.8/chrysalis/test_20250616/cull-topo-all

I looked over the masks for the Icos30km mesh in detail to make sure things looked as expected (see the image in the documentation and shared again below showing the ocean with land cells culled out).
image

@xylar
Copy link
Collaborator Author

xylar commented Jun 16, 2025

@sbrus89, is this something you would have time to review?

@xylar xylar requested a review from sbrus89 June 23, 2025 12:37
@xylar
Copy link
Collaborator Author

xylar commented Jul 30, 2025

@sbrus89, let's chat about this one today if there's time. I'd ideally like to get it in soon.

@xylar xylar removed the request for review from sbrus89 August 13, 2025 16:00
xylar added 11 commits August 14, 2025 07:51
When creating the ocean mask before remapping topography, we
exclude grounded ice by default but with this change it can be
retained as part of the ocean by setting a config option.
For now, we don't yet have a step for actually culling the
topography.
we now have separate documents for combine and remap tasks and
steps to keep the document from getting too unwieldy.
This version of MPAS-Tools has a bug fix
(MPAS-Dev/MPAS-Tools#643) that we need.
Add missing import
@xylar
Copy link
Collaborator Author

xylar commented Aug 14, 2025

I rebased and reran all tests successfully on Chrysalis. I wasn't able to get a review so I'm going to merge. I think that's fine, we can address any issues that turn up in future work.

@xylar xylar merged commit 63ccb08 into E3SM-Project:main Aug 14, 2025
5 checks passed
@xylar xylar deleted the add-cull-topo branch August 14, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e3sm/init Related to the e3sm/init component enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant