-
Notifications
You must be signed in to change notification settings - Fork 19
Add steps and tasks for culling topography #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
Author
|
@sbrus89, is this something you would have time to review? |
Collaborator
Author
|
@sbrus89, let's chat about this one today if there's time. I'd ideally like to get it in soon. |
When creating the ocean mask before remapping topography, we exclude grounded ice by default but with this change it can be retained as part of the ocean by setting a config option.
For now, we don't yet have a step for actually culling the topography.
we now have separate documents for combine and remap tasks and steps to keep the document from getting too unwieldy.
This version of MPAS-Tools has a bug fix (MPAS-Dev/MPAS-Tools#643) that we need.
Add missing import
Collaborator
Author
|
I rebased and reran all tests successfully on Chrysalis. I wasn't able to get a review so I'm going to merge. I think that's fine, we can address any issues that turn up in future work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This merge adds
e3sm/init/<mesh>/topo/culltasks for each supported base mesh, and associated steps for masking and then culling the base meshes to land and ocean regions (the latter with and without Antarctic ice-shelf cavities). A config option also allows a user to retain the grounded ice below Antarctica as part of the ocean domain (a need for future work on MALI coupling to MPAS-Ocean in the FAnSSIE project).This work requires a bug fix in
mpas_tools1.2.2 (which requires updating polaris to v0.8.0-alpha.3) that fixes writing CDF5 format files with logging enabled.The documentation has been reorganized to break out into separate documents the descriptions or combining and remapping topography, and then culling the base mesh based on this topography.
This merge also fixes a few issues discovered with
e3sm/init/<mesh>/topo/remaptasks and steps discovered in this development.Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes