-
Notifications
You must be signed in to change notification settings - Fork 19
Write output useful for Omega PRs #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b0962f5 to
6ec8da4
Compare
6ec8da4 to
8248d20
Compare
|
@sbrus89, this has been rebased and is now ready for you to have a look. |
sbrus89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar, I tested this on Perlmutter and it worked great. Thanks for adding this!
Polaris omega_pr suite
- PR build:
/global/cfs/cdirs/e3sm/sbrus/polaris_worktrees/omega_pr_output/e3sm_submodules/Omega/components/omega/build - PR workdir:
/pscratch/sd/s/sbrus/polaris_omega_pr_output - Machine:
pm-cpu - Compiler:
gnu - Build type: <Debug|Release>
- Log:
/pscratch/sd/s/sbrus/polaris_omega_pr_output/polaris_omega_pr.o45055520 - Result: All tests passed
Just two comments:
- I ran this in an interactive session, so the log file listed in the output doesn't actually exist. I'm not sure how easy it is to query if a job is interactive or not?
- Is it possible to add the baseline directory for runs that do baseline comparison?
I can add that but I think it isn't a good idea to run the suite interactively for purposes of posting on an Omega PR. We do want that log output available if needed. But I do also understand that Omega is super flaky on Perlmutter right now so an interactive job is the only reasonable option. |
8248d20 to
c4eb1cd
Compare
That should already be present. That was a lot of the extra work I had to add to the provenance. Did you try that and did it not show up? I'm pretty sure I tested and it worked for me but I'll try again to be sure. Update clearly I haven't done any recent baseline comparisons because I'm seeing #395 |
c4eb1cd to
a8f2d61
Compare
|
I tested this along with #398 and when I run Polaris
|
|
@sbrus89, I believe I have addressed both of your requests. I confirmed that the baseline information is, indeed, included when I run a comparison against a baseline. (Note that you need the baseline to also be created with this Polaris branch or it won't have the necessary provenance.) I also do not include the path to the log file if it doesn't exist. |
This merge adds the capability to write out a file like:
that is useful for copying and pasting into an Omega PR to provide information on
omega_prtesting. It works for any Polaris suite so could be used for MPAS-Ocean testing as well or other supported components in the future.To support the capability, this merge also adds more robust output to the
provenancefile during setup. It overwrites the this file rather than appending to it because the redundancy is more confusing than helpful with appending.Checklist
Testingcomment in the PR documents testing used to verify the changes