-
Notifications
You must be signed in to change notification settings - Fork 2
Fix dependencies #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies #42
Conversation
| - flake8 ==7.3.0 | ||
| - isort ==6.0.1 | ||
| #- mypy ==1.18.2 | ||
| - mypy ==1.18.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If, in the future, the latest version of mypy or another pinned linting or CI tool is not available on conda-forge, use the latest version available on conda-forge both here and in the pre-commit config file, rather than pulling the tool from PyPI. This was @tomvothecoder's suggestion the last time this happened as well.
forsyth2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the pyproject.toml also need the following?
- "matplotlib",
+ "matplotlib-base >=3.8.2",
I also noticed in that file:
qa = [
"black==24.10.1",
"flake8==7.1.1",
"flake8-isort==6.1.0",
"isort==5.13.2",
"mypy==1.11.2",
"pre-commit >=3.0.0",
"types-PyYAML >=6.0.0",
]
Should these match the versions in .pre-commit-config.yaml?
|
Yes, I believe the |
|
@forsyth2, actually, I'll just take care of it. Just as sec... |
| "black==25.1.0", | ||
| "flake8==7.3.0", | ||
| "flake8-isort==6.1.1", | ||
| "isort==6.0.1", | ||
| "mypy==1.18.2", | ||
| "pre-commit==4.3.0", | ||
| "types-PyYAML >=6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forsyth2, please double check these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these appear to match the current dev.yml and .pre-commit-config.yml.
Thanks!! |
|
@forsyth2, I think this is ready for you to merge if you're ready. |
|
GitHub Actions are passing and visual inspection looks good, merging. Thanks again @xylar! |
Summary
Some dependencies were updated recently in #25 and #38 in ways I do not think we want in the end. This PR aims to fix those dependencies
Objectives:
Select one: This pull request is...
Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other.
Small Change