-
Notifications
You must be signed in to change notification settings - Fork 14
Update example cfg #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example cfg #721
Conversation
|
After changing ts_years to 1850 as baseline, the global_time_series job exceed wall time limit (10hr). This is the only error when I tested this new cfg and likely related to the performance issue discovered earlier with zi-global-time-series. We will have to wait to merge this PR until the performance issue is addressed. |
|
Ok that makes sense; it looks like we have a chain of PRs to get through for this: |
|
@forsyth2 I updated this PR with the v3.1.0 features. I was considering adding PMP but decided to defer that until we transition the PMP tasks from experimental use to production. Let me know if it is reasonable. |
forsyth2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengzhuzhang Thanks, this looks good to me.
| # NOTE: This configuration generates approximately 220 tasks/jobs when fully enabled. | ||
| # Users should only enable the tasks and time periods they need based on their specific | ||
| # analysis requirements to reduce computational load and queue time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this, I'll just do a visual inspection.
✅ The web results appear to include all the requested plotting tasks:
| output = /lcrc/group/e3sm/ac.forsyth2/zppy_example_v3/v3.LR.historical_0051 | ||
| www = /lcrc/group/e3sm/public_html/diagnostic_output/ac.forsyth2/zppy_example_v3 | ||
| output = /lcrc/group/e3sm/ac.zhang40/zppy_example_v3.1/v3.LR.historical_0051 | ||
| www = /lcrc/group/e3sm/public_html/diagnostic_output/zppy_example/v3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might recommend making this v3.1.0 to match the version exactly.
|
@forsyth2 thanks for a review! I have addressed your comment, and will merge when checks are completed. |
Summary
Issue resolution:
Select one: This pull request is...
Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other.
Small Change
Big Change
1. Does this do what we want it to do?
Required:
If applicable:
2. Are the implementation details accurate & efficient?
Required:
If applicable:
zppy/conda, not just animportstatement.3. Is this well documented?
Required:
4. Is this code clean?
Required:
If applicable: