Conversation
forsyth2
left a comment
There was a problem hiding this comment.
@chengzhuzhang To continue legacy testing, I've added cfgs that are meant to be "frozen" in time at zppy v3.1.0. (Right now, they're identical copies of the main set of cfgs).
I think it would be over-testing to continue testing the v3.0.0 legacy cfgs as well, so my plan is to keep the cfgs but remove them from the default list (i.e., commenting them out in tests/integration/utils.py). That way, they can still be tested if questions of backwards compatibility arise or during more rigorous testing periods, like E3SM Unified testing.
Let me know if you have any questions/comments, otherwise I think this should be fine to merge.
|
You plan sounds good to me. Thanks! |
|
Sounds good, thanks! I'll go ahead and merge then. |
| "weekly_legacy_3.1.0_bundles", | ||
| "weekly_legacy_3.1.0_comprehensive_v2", | ||
| "weekly_legacy_3.1.0_comprehensive_v3", |
There was a problem hiding this comment.
This (the second commit, 4465ca4) is a minor update just for completeness. It's only relevant when TEST_SPECIFICS["cfgs_to_run"] == [] and I usually only run a subset of cfgs.
Summary
Objectives:
Select one: This pull request is...
Small Change