Add precip_pdf and mp_partition from e3sm diags#787
Conversation
| years = "1985:2014:30", | ||
| # NOTE: If you want to use the latest development environment of e3sm_diags, | ||
| # you can do something like the following: | ||
| environment_commands = "source /home/ac.zhang40/y/etc/profile.d/conda.sh; conda activate e3sm_diags_dev_py313" |
There was a problem hiding this comment.
Need to comment out after e3sm_unified released
|
@forsyth2 i believe this is ready to review. Let me know if code change makes sense, and the results can be viewed here: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/zppy_example/v3.2.0/v3.LR.historical_0051/. Thank you! |
forsyth2
left a comment
There was a problem hiding this comment.
Thanks @chengzhuzhang. By visual inspection, the code changes look reasonable. I'll add a commit to include the new sets in the integration test cfg. Currently waiting for nodes on Chrysalis to run.
forsyth2
left a comment
There was a problem hiding this comment.
@chengzhuzhang I've confirmed I can produce results using an updated test cfg:
Once this PR is merged, as part of main-branch testing I'll actually update expected results.
I've added a new commit to this PR that includes the relevant test cfg changes. I think this should be good to merge now. Thanks!
|
@forsyth2 thank you for reviewing and testing! |
Summary
Implemented PR scope to add two new e3sm_diags sets in zppy: first mp_partition (from e3sm_diags PR #1028), then precip_pdf (from PR #1023).
Changes include wiring both sets into zppy/templates/e3sm_diags.bash (imports + parameter objects + monthly/daily TS paths + model-vs-model reference wiring), adding dependency/path inference and required-parameter logic in zppy/e3sm_diags.py (mp_partition uses monthly TS deps, precip_pdf uses daily TS deps), updating available-set docs comment in zppy/defaults/default.ini, and extending unit coverage in tests/test_zppy_e3sm_diags.py for mvm checks, inferred reference paths, and TS dependency generation for both sets.
The results can be viewed here: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/zppy_example/v3.2.0/v3.LR.historical_0051/
Issue resolution:
e3sm_diagsPrecipitation PDF plots to integration tests #778Select one: This pull request is...
Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other.
Small Change
Big Change
1. Does this do what we want it to do?
Required:
If applicable:
2. Are the implementation details accurate & efficient?
Required:
If applicable:
zppy/conda, not just animportstatement.3. Is this well documented?
Required:
4. Is this code clean?
Required:
If applicable: