Skip to content

Clarify instruction source for stop guidance#796

Closed
Copilot wants to merge 1 commit intoreview-livvkitfrom
copilot/sub-pr-790-again
Closed

Clarify instruction source for stop guidance#796
Copilot wants to merge 1 commit intoreview-livvkitfrom
copilot/sub-pr-790-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 12, 2026

Summary

Clarify that the stop-on-failure guidance is defined by the environment’s
developer instructions, not by repository files.

Objectives:

  • State where the guidance is defined

  • Avoid implying AGENTS.md contains developer instructions

  • Instruction source

    • Document that the guidance comes from system/developer instructions

Issue resolution:

  • N/A

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major
    version

Please fill out either the "Small Change" or "Big Change" section (the latter
includes the numbered subsections), and delete the other.

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a
    single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

Big Change

  • To merge, I will use "Create a merge commit". That is, this change is large
    enough to require multiple units of work (i.e., it should be multiple commits).

1. Does this do what we want it to do?

Required:

  • Product Management: I have confirmed with the stakeholders that the
    objectives above are correct and complete.
  • Testing: I have added or modified at least one "min-case" configuration
    file to test this change. Every objective above is represented in at least one
    cfg.
  • Testing: I have considered likely and/or severe edge cases and have
    included them in testing.

If applicable:

  • Testing: this pull request introduces an important feature or bug fix that
    we must test often. I have updated the weekly-test configuration files, not
    just a "min-case" one.
  • Testing: this pull request adds at least one new possible parameter to the
    cfg. I have tested using this parameter with and without any other parameter
    that may interact with it.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.
  • Logic: I have left GitHub comments highlighting important pieces of code
    logic. I have had these code blocks reviewed by at least one other team member.

If applicable:

  • Dependencies: This pull request introduces a new dependency. I have
    discussed this requirement with at least one other team member. The dependency
    is noted in zppy/conda, not just an import statement.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand
    the functionality introduced by this pull request.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such
    that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

If applicable:

  • Software architecture: I have discussed relevant trade-offs in design
    decisions with at least one other team member. It is unlikely that this pull
    request will increase tech debt.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Mar 12, 2026
Copilot AI changed the title [WIP] Add integration testing for LIVVkit Fix livvkit template inclusion discovery Mar 12, 2026
Copilot AI requested a review from forsyth2 March 12, 2026 21:09
Copilot AI changed the title Fix livvkit template inclusion discovery Fix livvkit inclusion template discovery Mar 12, 2026
Copilot AI changed the title Fix livvkit inclusion template discovery Ensure LIVVkit inclusion templates are packaged Mar 12, 2026
Copilot AI changed the title Ensure LIVVkit inclusion templates are packaged Clarify instruction source for stop behavior Mar 12, 2026
Copilot AI changed the title Clarify instruction source for stop behavior Clarify instruction source for stop guidance Mar 12, 2026
@forsyth2 forsyth2 closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants