Clarify instruction source for stop guidance#796
Closed
Copilot wants to merge 1 commit intoreview-livvkitfrom
Closed
Clarify instruction source for stop guidance#796Copilot wants to merge 1 commit intoreview-livvkitfrom
Copilot wants to merge 1 commit intoreview-livvkitfrom
Conversation
Closed
Copilot
AI
changed the title
[WIP] Add integration testing for LIVVkit
Fix livvkit template inclusion discovery
Mar 12, 2026
Copilot
AI
changed the title
Fix livvkit template inclusion discovery
Fix livvkit inclusion template discovery
Mar 12, 2026
Copilot
AI
changed the title
Fix livvkit inclusion template discovery
Ensure LIVVkit inclusion templates are packaged
Mar 12, 2026
Copilot
AI
changed the title
Ensure LIVVkit inclusion templates are packaged
Clarify instruction source for stop behavior
Mar 12, 2026
Copilot
AI
changed the title
Clarify instruction source for stop behavior
Clarify instruction source for stop guidance
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify that the stop-on-failure guidance is defined by the environment’s
developer instructions, not by repository files.
Objectives:
State where the guidance is defined
Avoid implying AGENTS.md contains developer instructions
Instruction source
Issue resolution:
Select one: This pull request is...
version
Please fill out either the "Small Change" or "Big Change" section (the latter
includes the numbered subsections), and delete the other.
Small Change
single commit.
Big Change
enough to require multiple units of work (i.e., it should be multiple commits).
1. Does this do what we want it to do?
Required:
objectives above are correct and complete.
file to test this change. Every objective above is represented in at least one
cfg.
included them in testing.
If applicable:
we must test often. I have updated the weekly-test configuration files, not
just a "min-case" one.
cfg. I have tested using this parameter with and without any other parameter
that may interact with it.
2. Are the implementation details accurate & efficient?
Required:
logic. I have had these code blocks reviewed by at least one other team member.
If applicable:
discussed this requirement with at least one other team member. The dependency
is noted in
zppy/conda, not just animportstatement.3. Is this well documented?
Required:
the functionality introduced by this pull request.
4. Is this code clean?
Required:
that a new team member could understand what's happening.
If applicable:
decisions with at least one other team member. It is unlikely that this pull
request will increase tech debt.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.