Skip to content

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Oct 31, 2025

Summary

Objectives:

  • Address test issues found while testing Unified 1.12.0rc3 (zstash 1.5.0rc4)

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Oct 31, 2025
@forsyth2 forsyth2 added the Testing Files in `tests` modified label Oct 31, 2025
Copy link
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just test updates, so if no functional changes come in, zstash won't actually need a rc5.

Comment on lines +365 to +368
if [ "$src_machine" != "perlmutter" ]; then
echo "Testing transfer to NERSC Perlmutter ###################################"
test_single_auth_code ${path_to_repo} NERSC_PERLMUTTER_ENDPOINT ${perlmutter_dst_dir}
fi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was running in to login problems while testing Perlmutter transferring to Perlmutter. I thought I had done that successfully before, but in any case, I don't really think this is an important case to worry about testing (i.e., there's not much of a need to Globus transfer files to the same machine).

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Nov 4, 2025

I've completed testing on Chrysalis, Compy, Perlmutter, so I don't think there's anything more to add for this PR. Since this only touches files in tests/, there's no need for a new RC.

@forsyth2 forsyth2 merged commit d0a5934 into main Nov 4, 2025
9 of 10 checks passed
@forsyth2 forsyth2 deleted the test-updates-for-rc5 branch November 4, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Files in `tests` modified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants