fix(cs-fixer): setRiskyAllowed(true)を追加#6568
Open
nanasess wants to merge 2 commits intoEC-CUBE:4.3-symfony7from
Open
fix(cs-fixer): setRiskyAllowed(true)を追加#6568nanasess wants to merge 2 commits intoEC-CUBE:4.3-symfony7from
nanasess wants to merge 2 commits intoEC-CUBE:4.3-symfony7from
Conversation
phpdoc_to_param_type, phpdoc_to_return_type, phpdoc_to_property_type などのriskyフィクサーを使用するために必要な設定を追加。 これにより--allow-risky=yesオプションなしで実行可能になる。 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…fixer-risky-allowed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.3-symfony7 #6568 +/- ##
================================================
+ Coverage 82.33% 82.46% +0.13%
================================================
Files 482 482
Lines 25691 25691
================================================
+ Hits 21152 21187 +35
+ Misses 4539 4504 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
PHP CS Fixerの設定に
setRiskyAllowed(true)を追加し、riskyフィクサーを--allow-risky=yesオプションなしで実行可能にします。現在の設定では
phpdoc_to_param_type,phpdoc_to_return_type,phpdoc_to_property_typeなどのriskyフィクサーが有効になっていますが、setRiskyAllowed(true)が設定されていないため、huskyを利用したpre-commitフック実行時に以下の警告が発生していました:方針(Policy)
setRiskyAllowed(true)を設定する必要があります実装に関する補足(Appendix)
.php-cs-fixer.dist.phpに->setRiskyAllowed(true)を1行追加しただけのシンプルな変更です。テスト(Test)
vendor/bin/php-cs-fixer fix --dry-runでエラーなく実行できることを確認相談(Discussion)
特にありません。
マイナーバージョン互換性保持のための制限事項チェックリスト
🤖 Generated with Claude Code