Open
Conversation
ハードコードされていた日本語メッセージを翻訳フィルタを使用するように変更
- 変更前: data-message="カートから商品を削除してもよろしいですか?"
- 変更後: data-message="{{ 'front.cart.delete__confirm'|trans }}"
翻訳キーは messages.ja.yaml および messages.en.yaml に既存
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #6585 by internationalizing a hardcoded Japanese confirmation message for cart item deletion. The change replaces a hardcoded Japanese string with a translation key that already exists in the messages files.
Changes:
- Replaced hardcoded Japanese confirmation message "カートから商品を削除してもよろしいですか?" with translation filter usage
{{ 'front.cart.delete__confirm'|trans }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6592 +/- ##
==========================================
- Coverage 82.70% 82.70% -0.01%
==========================================
Files 480 480
Lines 26507 26507
==========================================
- Hits 21923 21922 -1
- Misses 4584 4585 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ハードコードされていた日本語メッセージを翻訳フィルタを使用するように変更
概要(Overview・Refs Issue)
Fixes #6585
方針(Policy)
すでにmessagesファイルにキーが存在したので使用
テスト(Test)
画面で確認

マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目