Skip to content

improvement: 未実装のイベント定数を削除 (#6529) #6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ttokoro20240902 wants to merge 4 commits into
base: 4.4
Choose a base branch
from
+1 −56
Open

improvement: 未実装のイベント定数を削除 (#6529) #6894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
882ecf3
improvement: 未実装のイベント定数を削除 (#6529)
ttokoro20240902 Jul 6, 2026
19d3ecd
improvement: 未使用のイベント定数を追加削除 (#6529)
ttokoro20240902 Jul 15, 2026
4cbce4c
docs(skill): CSV Skill の CSV エクスポートイベント記述を実態に合わせる (#6529)
ttokoro20240902 Jul 15, 2026
42806b1
Merge branch '4.4' into feature/6529-remove-unused-events
ttokoro20240902 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/csv/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ try {
- **管理画面で増やせる出力項目**は `dtb_csv` のレコード追加（CSV 設定画面）で完結する。コード変更は不要。
- **コードで列を足したい**場合は、コア改変ではなく **CSV エクスポートイベントを購読**する。
`EccubeEvents` に種別ごとのイベントがある:
- `ADMIN_ORDER_CSV_EXPORT_ORDER` / `ADMIN_ORDER_CSV_EXPORT_SHIPPING`
- `ADMIN_ORDER_CSV_EXPORT_ORDER`（受注・出荷 CSV 共通。`OrderController::exportCsv()` は受注/出荷どちらのエクスポートでもこの1イベントを dispatch する）
- `ADMIN_PRODUCT_CSV_EXPORT` / `ADMIN_CUSTOMER_CSV_EXPORT`
- `ADMIN_PRODUCT_CATEGORY_CSV_EXPORT` / `ADMIN_PRODUCT_CLASS_NAME_CSV_EXPORT` / `ADMIN_PRODUCT_CLASS_CATEGORY_CSV_EXPORT`
購読側で `EventArgs` から `ExportCsvRow` を受け取り、`setData()` / `pushData()` で列を追加する
Expand Down
55 changes: 0 additions & 55 deletions src/Eccube/Event/EccubeEvents.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ final class EccubeEvents
public const ADMIN_ADMIM_LOGIN_INITIALIZE = 'admin.admin.login.initialize';

// index
public const ADMIN_ADMIM_INDEX_INITIALIZE = 'admin.admin.index.initialize';
public const ADMIN_ADMIM_INDEX_ORDER = 'admin.admin.index.order';
public const ADMIN_ADMIM_INDEX_SALES = 'admin.admin.index.sales';
public const ADMIN_ADMIM_INDEX_COMPLETE = 'admin.admin.index.complete';
Expand Down Expand Up @@ -63,8 +62,6 @@ final class EccubeEvents
* Admin/Content/LayoutController
*/
// index
public const ADMIN_CONTENT_LAYOUT_INDEX_INITIALIZE = 'admin.content.layout.index.initialize';
public const ADMIN_CONTENT_LAYOUT_INDEX_COMPLETE = 'admin.content.layout.index.complete';

/**
* Admin/Content/NewsController
Expand Down Expand Up @@ -149,14 +146,9 @@ final class EccubeEvents
// index
public const ADMIN_ORDER_MAIL_INDEX_INITIALIZE = 'admin.order.mail.index.initialize';
public const ADMIN_ORDER_MAIL_INDEX_CHANGE = 'admin.order.mail.index.change';
public const ADMIN_ORDER_MAIL_INDEX_CONFIRM = 'admin.order.mail.index.confirm';
public const ADMIN_ORDER_MAIL_INDEX_COMPLETE = 'admin.order.mail.index.complete';

// mailAll
public const ADMIN_ORDER_MAIL_MAIL_ALL_INITIALIZE = 'admin.order.mail.mail.all.initialize';
public const ADMIN_ORDER_MAIL_MAIL_ALL_CHANGE = 'admin.order.mail.mail.all.change';
public const ADMIN_ORDER_MAIL_MAIL_ALL_CONFIRM = 'admin.order.mail.mail.all.confirm';
public const ADMIN_ORDER_MAIL_MAIL_ALL_COMPLETE = 'admin.order.mail.mail.all.complete';

/**
* Admin/Order/OrderController
Expand All @@ -166,20 +158,16 @@ final class EccubeEvents
public const ADMIN_ORDER_INDEX_SEARCH = 'admin.order.index.search';

// delete
public const ADMIN_ORDER_DELETE_COMPLETE = 'admin.order.delete.complete';

// exportOrder
public const ADMIN_ORDER_CSV_EXPORT_ORDER = 'admin.order.csv.export.order';

// exportShipping
public const ADMIN_ORDER_CSV_EXPORT_SHIPPING = 'admin.order.csv.export.shipping';

/**
* Admin/Shipping/ShippingController
*/
// index
public const ADMIN_SHIPPING_INDEX_INITIALIZE = 'admin.shipping.index.initialize';
public const ADMIN_SHIPPING_INDEX_SEARCH = 'admin.shipping.index.search';

/**
* Admin/Product/CategoryController
Expand Down Expand Up @@ -242,15 +230,6 @@ final class EccubeEvents
/**
* Admin/Product/ProductClassController
*/
// index
public const ADMIN_PRODUCT_PRODUCT_CLASS_INDEX_INITIALIZE = 'admin.product.product.class.index.initialize';
public const ADMIN_PRODUCT_PRODUCT_CLASS_INDEX_CLASSES = 'admin.product.product.class.index.classes';

// edit
public const ADMIN_PRODUCT_PRODUCT_CLASS_EDIT_INITIALIZE = 'admin.product.product.class.edit.initialize';
public const ADMIN_PRODUCT_PRODUCT_CLASS_EDIT_COMPLETE = 'admin.product.product.class.edit.complete';
public const ADMIN_PRODUCT_PRODUCT_CLASS_EDIT_UPDATE = 'admin.product.product.class.edit.update';
public const ADMIN_PRODUCT_PRODUCT_CLASS_EDIT_DELETE = 'admin.product.product.class.edit.delete';

/**
* Admin/Product/ProductController
Expand All @@ -274,7 +253,6 @@ final class EccubeEvents
public const ADMIN_PRODUCT_COPY_COMPLETE = 'admin.product.copy.complete';

// display
public const ADMIN_PRODUCT_DISPLAY_COMPLETE = 'admin.product.display.complete';

// export
public const ADMIN_PRODUCT_CSV_EXPORT = 'admin.product.csv.export';
Expand Down Expand Up @@ -340,8 +318,6 @@ final class EccubeEvents
// delete
public const ADMIN_SETTING_SHOP_TAX_RULE_DELETE_COMPLETE = 'admin.setting.shop.tax.rule.delete.complete';
// editParameter
public const ADMIN_SETTING_SHOP_TAX_RULE_EDIT_PARAMETER_INITIALIZE = 'admin.setting.shop.tax.rule.edit.parameter.initialize';
public const ADMIN_SETTING_SHOP_TAX_RULE_EDIT_PARAMETER_COMPLETE = 'admin.setting.shop.tax.rule.edit.parameter.complete';

/**
* Admin/Setting/System/AuthorityController
Expand Down Expand Up @@ -381,7 +357,6 @@ final class EccubeEvents
public const ADMIN_SETTING_SYSTEM_MEMBER_EDIT_COMPLETE = 'admin.setting.system.member.edit.complete';

// delete
public const ADMIN_SETTING_SYSTEM_MEMBER_DELETE_INITIALIZE = 'admin.setting.system.member.delete.initialize';
public const ADMIN_SETTING_SYSTEM_MEMBER_DELETE_COMPLETE = 'admin.setting.system.member.delete.complete';

/**
Expand Down Expand Up @@ -427,7 +402,6 @@ final class EccubeEvents
public const FRONT_MYPAGE_MYPAGE_FAVORITE_SEARCH = 'front.mypage.mypage.favorite.search';

// delete
public const FRONT_MYPAGE_MYPAGE_DELETE_INITIALIZE = 'front.mypage.mypage.delete.initialize';
public const FRONT_MYPAGE_MYPAGE_DELETE_COMPLETE = 'front.mypage.mypage.delete.complete';

/**
Expand All @@ -441,26 +415,13 @@ final class EccubeEvents
* CartController
*/
// index
public const FRONT_CART_INDEX_INITIALIZE = 'front.cart.index.initialize';
public const FRONT_CART_INDEX_COMPLETE = 'front.cart.index.complete';
// add
public const FRONT_CART_ADD_INITIALIZE = 'front.cart.add.initialize';
public const FRONT_CART_ADD_COMPLETE = 'front.cart.add.complete';
public const FRONT_CART_ADD_EXCEPTION = 'front.cart.add.exception';

// up
public const FRONT_CART_UP_INITIALIZE = 'front.cart.up.initialize';
public const FRONT_CART_UP_COMPLETE = 'front.cart.up.complete';
public const FRONT_CART_UP_EXCEPTION = 'front.cart.up.exception';

// down
public const FRONT_CART_DOWN_INITIALIZE = 'front.cart.down.initialize';
public const FRONT_CART_DOWN_COMPLETE = 'front.cart.down.complete';
public const FRONT_CART_DOWN_EXCEPTION = 'front.cart.down.exception';

// remove
public const FRONT_CART_REMOVE_INITIALIZE = 'front.cart.remove.initialize';
public const FRONT_CART_REMOVE_COMPLETE = 'front.cart.remove.complete';

// buystep
public const FRONT_CART_BUYSTEP_INITIALIZE = 'front.cart.buystep.initialize';
Expand Down Expand Up @@ -497,14 +458,9 @@ final class EccubeEvents
// index
public const FRONT_PRODUCT_INDEX_INITIALIZE = 'front.product.index.initialize';
public const FRONT_PRODUCT_INDEX_SEARCH = 'front.product.index.search';
public const FRONT_PRODUCT_INDEX_COMPLETE = 'front.product.index.complete';
public const FRONT_PRODUCT_INDEX_DISP = 'front.product.index.disp';
public const FRONT_PRODUCT_INDEX_ORDER = 'front.product.index.order';

// detail
public const FRONT_PRODUCT_DETAIL_INITIALIZE = 'front.product.detail.initialize';
public const FRONT_PRODUCT_DETAIL_FAVORITE = 'front.product.detail.favorite';
public const FRONT_PRODUCT_DETAIL_COMPLETE = 'front.product.detail.complete';

/**
* 商品詳細ページの構造化データ（JSON-LD）を組み立てる際に発火.
Expand All @@ -527,32 +483,22 @@ final class EccubeEvents
* ShoppingController
*/
// index
public const FRONT_SHOPPING_INDEX_INITIALIZE = 'front.shopping.index.initialize';

// confirm
public const FRONT_SHOPPING_CONFIRM_INITIALIZE = 'front.shopping.confirm.initialize';
public const FRONT_SHOPPING_CONFIRM_PROCESSING = 'front.shopping.confirm.processing';
public const FRONT_SHOPPING_CONFIRM_COMPLETE = 'front.shopping.confirm.complete';

// complete
public const FRONT_SHOPPING_COMPLETE_INITIALIZE = 'front.shopping.complete.initialize';

// delivery
public const FRONT_SHOPPING_DELIVERY_INITIALIZE = 'front.shopping.delivery.initialize';
public const FRONT_SHOPPING_DELIVERY_COMPLETE = 'front.shopping.delivery.complete';

// payment
public const FRONT_SHOPPING_PAYMENT_INITIALIZE = 'front.shopping.payment.initialize';
public const FRONT_SHOPPING_PAYMENT_COMPLETE = 'front.shopping.payment.complete';

// shippingChange
public const FRONT_SHOPPING_SHIPPING_CHANGE_INITIALIZE = 'front.shopping.shipping.change.initialize';

// shipping
public const FRONT_SHOPPING_SHIPPING_COMPLETE = 'front.shopping.shipping.complete';

// shippingEditChange
public const FRONT_SHOPPING_SHIPPING_EDIT_CHANGE_INITIALIZE = 'front.shopping.shipping.edit.change.initialize';

// shippingEdit
public const FRONT_SHOPPING_SHIPPING_EDIT_INITIALIZE = 'front.shopping.shipping.edit.initialize';
Expand All @@ -569,7 +515,6 @@ final class EccubeEvents
public const FRONT_SHOPPING_NONMEMBER_COMPLETE = 'front.shopping.nonmember.complete';

// shippingMultipleChange
public const FRONT_SHOPPING_SHIPPING_MULTIPLE_CHANGE_INITIALIZE = 'front.shopping.shipping.multiple.change.initialize';

// shippingMultiple
public const FRONT_SHOPPING_SHIPPING_MULTIPLE_INITIALIZE = 'front.shopping.shipping.multiple.initialize';
Expand Down
Loading