Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
EC-CUBE 4.4(Symfony 7.4 / Doctrine ORM 3.0 / PHP 8.2+)にメルマガ管理プラグインを対応させます。
公式の関連商品プラグイン EC-CUBE/related-product-plugin#91 と
4.4 マイグレーションドキュメント EC-CUBE/doc4.ec-cube.net#346 に倣った移行です。
4.3 と 4.4 はアノテーション必須/属性必須の違いで非互換のため、
4.2ブランチ(MailMagazine42)とは別に4.4ブランチ(MailMagazine44)で保守します。本 PR は4.4ブランチをベースにしています。主な変更点
Symfony 7 対応
@Routeアノテーション →#[Route]属性へ移行、戻り値型・引数型を明示buildForm(): void等の戻り値型・引数型を明示コード名リネーム
MailMagazine42→MailMagazine42Plugin\MailMagazine42\...)/ composer 名(ec-cube/mailmagazine44)/extra.code/ version4.4.0@MailMagazine42)/ 管理ナビキー / CIplugin_codePHPUnit 11 対応
phpunit.xml.distを新形式へ(<source>/<extensions>、DAMA\...\PHPUnitExtension): void/ 引数型を付与CI / 開発ツール一式(PR#91 と同等)
main.yml: EC-CUBE 4.4 / PHP 8.2-8.5 / MySQL8・PostgreSQL マトリクス、static-analysisジョブ(php-cs-fixer / rector / phpstan)を追加release.yml: 開発・テスト用ファイルを配布パッケージから除外phpstan.neon.dist/Resource/rector.php/Resource/.php-cs-fixer.dist.php/CLAUDE.md/.gitignoreを追加動作確認(EC-CUBE 4.4 / PHP 8.2 / SQLite、docker-compose)
--dry-run): 差分ゼロ--dry-run): 変更ゼロ🤖 Generated with Cursor
Summary by CodeRabbit
新機能
改善
ドキュメント