-
Notifications
You must be signed in to change notification settings - Fork 23
Add clang-tidy CI test #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EZoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, all CI checks seem successful, so it's probably ready to merge. I left only two minor notes related to inline comments that might have been copied from WarpX.
Co-authored-by: Edoardo Zoni <[email protected]>
|
Restarting CI because of old PR. |
ax3l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that LGTM.
|
@lucafedeli88 let me know if you like to tag a new |
This PR introduces a new CI test that runs
clang-tidyon all the tests and demos ofpicsar_qed.Included/excluded
clang-tidychecks as well as check options can be found in.clang-tidy. For the moment, this configuration file is identical to what is used in WarpX.The PR also fixes all the issues found with the new
clang-tidyCI test. In order to fix some issues properly, now C++17 is used (up until now the library used C++14)