Update mu_0, alpha to enforce consistency between constants #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
commented
Apr 1, 2025
Comment on lines
52
to
+55
| //(unfortunately, sqrt is not constexpr) | ||
| template<typename RealType = double> | ||
| constexpr auto sqrt_4_pi_fine_structure = | ||
| RealType(0.3028221207683449); | ||
| RealType(0.3028221207690299); |
Member
Author
There was a problem hiding this comment.
Please double check this too, since it is hard coded.
Member
|
Note that in WarpX, I added some comments in the code noting why the constants differ from the CODATA2022 values. Maybe do the same here. |
lucafedeli88
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the values of the vacuum permeability$\mu_0$ and the fine structure constant $\alpha$ to enforce consistency between constants (e.g., $c^2 = 1/(\epsilon_0 \mu_0)$ , etc.), following what is done in BLAST-WarpX/warpx#5661.
I think we should merge #60 first and then rebase here.