Skip to content

Localize authentication success message #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GLWine wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Localize authentication success message #2617

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa1efc
Localize authentication success message
GLWine Feb 12, 2026
eda76f5
Fix: Added missing #LANG comments to lines 672 and 67
GLWine Feb 14, 2026
2092fa4
Add authentication success localization
GLWine Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions companion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,13 @@ def auth_callback(self) -> None:
self.auth = None
raise # Bad thing happened
if IS_FROZEN:
tk.messagebox.showinfo(title="Authentication Successful", # type: ignore
message="Authentication with cAPI Successful.\n"
"You may now close the Frontier login tab if it is still open.")
tk.messagebox.showinfo( # type: ignore
title=tr.tl("Authentication Successful"),
Copy link
Contributor

@Rixxan Rixxan Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need LANG comments for the AST and to be added to en.template.

Similar examples can be found in the code, such as:

label=tr.tl("Open in {URL}").format(URL=url), # LANG: Open Element In Selected Provider

Copy link
Contributor Author

@GLWine GLWine Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it will be okay now?

Copy link
Contributor Author

@GLWine GLWine Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rixxan up

message=tr.tl(
"Authentication with cAPI Successful.{CR}"
"You may now close the Frontier login tab if it is still open."
).format(CR="\n")
)

def close(self) -> None:
"""Close the `request.Session()."""
Expand Down
Loading