Upgrades pt 4: Dependency updates & Old gem removal#863
Open
Upgrades pt 4: Dependency updates & Old gem removal#863
Conversation
esoterik
force-pushed
the
2021_gem_purge
branch
from
62b850a to
26aba5c
Compare
esoterik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review / merge after #862
Upgrades old gems (notably FactoryGirl -> FactoryBot and paperclip -> kt-paperclip), removes old / outdated / unused gems.
The only notable visible change here is the removal of the user ranking system (we were including a very old gem just to do percentile ranks for this feature); I can re-implement it if needed.