Skip to content

WIP Quick changes to Flat UI (#1461)#1486

Closed
andresbase wants to merge 6 commits into
EFForg:masterfrom
andresbase:ui-flat-2
Closed

WIP Quick changes to Flat UI (#1461)#1486
andresbase wants to merge 6 commits into
EFForg:masterfrom
andresbase:ui-flat-2

Conversation

@andresbase

@andresbase andresbase commented Jul 12, 2017

Copy link
Copy Markdown

Quick fixes for #1461

  • Same greens for toggles in lists.
  • Size of hints when going into options so they don't run into rows
  • Undo arrows are misaligned with the toggles (popup and options page)
  • Top toolbox vertical alignment.

The vertical alignment of toolbox (where shadow was removed) is indeed aligned but looks weird so I changed the padding on the top from 1 to 3px. It looks like this:

comppb_padding

@andresbase andresbase self-assigned this Jul 12, 2017
@andresbase andresbase added enhancement ui User interface modifications; related to but not the same as the "ux" label labels Jul 12, 2017
@andresbase andresbase added this to the W28-29 milestone Jul 12, 2017
@andresbase
andresbase requested a review from ghostwords July 12, 2017 00:07
@ghostwords

ghostwords commented Jul 12, 2017

Copy link
Copy Markdown
Member

Got two more items to add to the list:

  • Undo arrows are misaligned with the toggles (popup and options page)
  • The screenshots in the first-time walkthrough (open popup and click on the "?" in the upper right) show the old toggles

@ghostwords ghostwords left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we restore the switches to the old height (14 instead of 18 px), instead of tweaking row height/tooltip padding? Would need to shorten the handles image. Should take care of tooltip and undo arrow issues.

@andresbase

Copy link
Copy Markdown
Author

Added the alignment for the arrows as it's just one change.
The old message is gone too.

alignarrow

@ghostwords ghostwords left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header tooltips are still misaligned (not centered vertically):
screenshot from 2017-07-14 11 08 28

@ghostwords

Copy link
Copy Markdown
Member

Could you rebase your branch from master, so that you have the latest patch to ignore Firefox ESR?

A bunch of other tests are failing, for example, test_cookie_tracker_detection here. The test may need to be updated, not sure.

@ghostwords

Copy link
Copy Markdown
Member

I like the old height (14px) of the slider toggles more.

@andresbase

Copy link
Copy Markdown
Author

The toolbox is now aligned, there is an issue with it's alignment on the options page that has been there for a while. Not sure if I'll have time but will try before the release.

toolbox

I tried different sizes these days for the toggles in different screens/resolutions. I think the new size fits better for most screens. 14 looks wrong even if I fix all the other heights, it just ends up looking crammed.

togglesizes

@ghostwords

ghostwords commented Jul 16, 2017

Copy link
Copy Markdown
Member

The current production design:

current-design

The new toggles in master right now:

new-sliders

The same toggles reduced to current design's height:

new-sliders-current-height

All three next to each other:

side-by-side

@ghostwords

Copy link
Copy Markdown
Member

I prefer the new toggles reduced to current design's height.

@koops76 @ghinda Any feedback regarding #1486 (comment)?

@ghinda

ghinda commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

I think removing the rounded borders on the handle would look slightly better.

eg.
pb-no-radius

Other than that, looks good.

@ghostwords

Copy link
Copy Markdown
Member

I reverted the updated toggles PR merge from master in 4164b3d as we still have some fixes to make before releasing the UI updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ui User interface modifications; related to but not the same as the "ux" label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants