Add mdfp entry for msnbc.com, newsvine.com#1574
Merged
Merged
Conversation
Contributor
Author
|
EDIT: Closing and reopening to rerun build. Firefox beta build is failing due to the following Selenium test timing out: def test_should_not_detect_ls_of_third_party_script(self):
# a third-party script included by the top page (not a 3rd party frame)
self.load_url("https://rawgit.com/gunesacar/b366e3b03231dbee9709fe0a614faf10/raw/48e02456aa257e272092b398772a712391cf8b11/localstorage_from_third_party_script.html", wait_on_site=5)
self.assertFalse(self.detected_tracking_by("githack.com"))This seems to be an issue caused by either:
|
cowlicks
reviewed
Aug 15, 2017
| ], | ||
| ["mobilism.org.in", "mobilism.org"], | ||
| ["morganstanley.com", "morganstanleyclientserv.com", "stockplanconnect.com", "ms.com"], | ||
| ["msnbc.com", "newsvine.com"], |
Contributor
There was a problem hiding this comment.
I think this is indented with a tab, can you replace it with 2 spaces?
Contributor
Author
There was a problem hiding this comment.
Yeah, my bad. Accidentally had shiftwidth and tabstop set in Vim without expandtab, so it looked right on my end despite the difference.
Contributor
|
Thanks @eenblam ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1293. Follows up on and closes #1570.