Skip to content

Add mdfp entry for msnbc.com, newsvine.com#1574

Merged
cowlicks merged 2 commits into
EFForg:masterfrom
eenblam:fix-1293
Aug 15, 2017
Merged

Add mdfp entry for msnbc.com, newsvine.com#1574
cowlicks merged 2 commits into
EFForg:masterfrom
eenblam:fix-1293

Conversation

@eenblam

@eenblam eenblam commented Aug 15, 2017

Copy link
Copy Markdown
Contributor

Fixes #1293. Follows up on and closes #1570.

@eenblam

eenblam commented Aug 15, 2017

Copy link
Copy Markdown
Contributor Author

EDIT: Closing and reopening to rerun build.

Firefox beta build is failing due to the following Selenium test timing out:

def test_should_not_detect_ls_of_third_party_script(self):
    # a third-party script included by the top page (not a 3rd party frame)
    self.load_url("https://rawgit.com/gunesacar/b366e3b03231dbee9709fe0a614faf10/raw/48e02456aa257e272092b398772a712391cf8b11/localstorage_from_third_party_script.html", wait_on_site=5)
    self.assertFalse(self.detected_tracking_by("githack.com"))

This seems to be an issue caused by either:

  1. the network/Travis. Can we retry the build?
  2. SuperCookieTest.detected_tracking_by checking the snitch map. I'm not sure how the requested change would create such a drastic hit to performance, but I'm looking into it presently.

@eenblam eenblam closed this Aug 15, 2017
@eenblam eenblam reopened this Aug 15, 2017
Comment thread src/js/multiDomainFirstParties.js Outdated
],
["mobilism.org.in", "mobilism.org"],
["morganstanley.com", "morganstanleyclientserv.com", "stockplanconnect.com", "ms.com"],
["msnbc.com", "newsvine.com"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is indented with a tab, can you replace it with 2 spaces?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my bad. Accidentally had shiftwidth and tabstop set in Vim without expandtab, so it looked right on my end despite the difference.

@cowlicks

Copy link
Copy Markdown
Contributor

Thanks @eenblam !

@cowlicks
cowlicks merged commit 9625100 into EFForg:master Aug 15, 2017
@ghostwords ghostwords added the MDFP Multi-domain first parties: lists of domains that should be treated as related to each other label Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MDFP Multi-domain first parties: lists of domains that should be treated as related to each other

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cdn.lib.newsvine.com breaks video

3 participants