-
-
Notifications
You must be signed in to change notification settings - Fork 411
Re-implement breakage note with close button and without tooltipster #3146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Need to replace tooltipster to get the note in the correct place in the DOM for screenreader order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sign-in note may take up more header space, depending on the language. In English, the note covers the show/hide sliders header (with the "what is a tracker" link), at least on sites with enough domains like nytimes.com. In Russian, the note will also cover most of the Badger logo and top right corner icons.
I don't think we want to be able to tab through things obscured by the note. I also think the note should be the first thing we tab to, followed by the domain toggle the note points to.
Maybe showing the note should gray out header elements and remove them from tab order? (I'm not sure how to solve this yet, but it seems like this is a problem.)
0f80fcc to
a597b51
Compare



Closes #3034