Skip to content

Conversation

@lenacohen
Copy link
Contributor

@lenacohen lenacohen commented Oct 22, 2025

  • Re-implement the Google sign-in breakage note to move it from the end of the DOM to a logical place for screenreader users
    • Tooltipster does not have an option for this and seemed to undo moving the tooltip root in functionReady
  • Made closing the tooltip more clear/accessible by removing click to close and adding a close button (with slightly different styling than Add close icon to breakage note tooltip #3034). This also allows users to highlight/copy text without it closing the tooltip.

Closes #3034

Need to replace tooltipster to get the note in the correct place in the DOM for screenreader order
@lenacohen
Copy link
Contributor Author

lenacohen commented Oct 22, 2025

Current implementation:
Screenshot 2025-10-22 at 10 46 17 AM

Slightly different margin and placement for the close button (with existing tooltip shown for comparison):
Screenshot 2025-10-21 at 12 53 25 PM

Screenshot 2025-10-21 at 12 50 30 PM

@lenacohen lenacohen added a11y Accessibility ui User interface modifications; related to but not the same as the "ux" label labels Oct 23, 2025
Copy link
Member

@ghostwords ghostwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sign-in note may take up more header space, depending on the language. In English, the note covers the show/hide sliders header (with the "what is a tracker" link), at least on sites with enough domains like nytimes.com. In Russian, the note will also cover most of the Badger logo and top right corner icons.

I don't think we want to be able to tab through things obscured by the note. I also think the note should be the first thing we tab to, followed by the domain toggle the note points to.

Maybe showing the note should gray out header elements and remove them from tab order? (I'm not sure how to solve this yet, but it seems like this is a problem.)

@ghostwords ghostwords force-pushed the google-signin-accessibility branch 4 times, most recently from 0f80fcc to a597b51 Compare October 30, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility ui User interface modifications; related to but not the same as the "ux" label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants