Conversation
|
Had to add one more fix, the autocorrect was capitalizing the commands causing them to fail entirely. |
installer-gui/src-tauri/src/lib.rs
Outdated
| app_handle | ||
| .emit("installer-output", output) | ||
| .expect("Error sending Rayhunter CLI installer output to GUI frontend"); | ||
| let _ = app_handle.emit("installer-output", output); |
There was a problem hiding this comment.
oof. i assume you hit this? i had hoped this was the kind of thing that would never fail. did piping the CLI installer output to the GUI ever work for you?
i'm a little hesitant to just silently drop output like this. i agree crashing is bad if something like this can happen, but i worry that missing output will lead to a pretty confusing UX for some users
please let me know your experience here and if you have any other thoughts on a path forward here
other than this, i have no concerns about this PR. thanks again BeigeBox!
There was a problem hiding this comment.
I didn't run into it, I just have done some IPC stuff before and saw that it would cause the app to crash. We could extend it in the future to be more communicative. I just had a few moments last night and figured I would get the initial low hanging fruit sorted.
There was a problem hiding this comment.
gotcha. in that case, i'd personally prefer you leave this line as it is in main and we can revisit it when/if it becomes a problem
if you do that, i'll merge this
3 participants
Pull Request Checklist
cargo fmt.Small fixes to improve input validation, and not have the gui crash if there's an IPC issue.