Skip to content

Conversation

@luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Mar 8, 2025

Found via codespell -q 3 -D ../dictionary.txt -S "*.lang,*.ps,*.rtf,./resources/lang,./doc/rpm-build/debian.changes,./api/js/tinymce" -L pard,preserv,sie,stati,useable

Found via `codespell -q 3 -D ../dictionary.txt -S "*.lang,*.ps,*.rtf,./resources/lang,./doc/rpm-build/debian.changes,./api/js/tinymce" -L pard,preserv,sie,stati,useable`
@ralfbecker
Copy link
Member

There is a problem in changing / correcting typos in text in lang(...) calls. If you change these, you have to change the phrase in our translation-files too, otherwise they won't be found anymore and the (fixed) english text is shown.

So, if you change the text in a lang-call, e.g. you also have to change the phrase in ALL translation files, e.g. EN one, DE one, and so on.
As you see in the above example, the typo is already fixed in the actually translation.

It's probably nice to still fix these, ignoring everything which is not a comment might be the easier option.

Strings (not comments!), which are not wrapped in lang(...) calls, might still be translated inplizitly, e.g. settings hook.

I don't want to stop your enthusiasm, but I can't merge the request like this, nor do I have the time to check and fix every single changed line :(

Maybe configuring codespell to only change PHP comments is the more efficient options.

Ralf

@luzpaz
Copy link
Contributor Author

luzpaz commented Mar 8, 2025

Thank. I will see how to modify things. Thanks for the heads up.

@luzpaz luzpaz marked this pull request as draft March 8, 2025 15:42
@luzpaz
Copy link
Contributor Author

luzpaz commented Mar 10, 2025

There is a problem in changing / correcting typos in text in lang(...) calls. If you change these, you have to change the phrase in our translation-files too, otherwise they won't be found anymore and the (fixed) english text is shown.

This is very antiquated. Other projects generate translations files from one source. Is there any plan to change this in the future ?

@luzpaz luzpaz marked this pull request as ready for review March 10, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants