Skip to content

fix(localega-tsd-proxy): fixes calls to LS login per request #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joshbaskaran wants to merge 31 commits into
base: main
Choose a base branch
from
Open

fix(localega-tsd-proxy): fixes calls to LS login per request #687

joshbaskaran wants to merge 31 commits into from

Conversation

@joshbaskaran
Copy link
Contributor

@joshbaskaran joshbaskaran commented Jan 16, 2026

fixes #686

@joshbaskaran joshbaskaran linked an issue Jan 16, 2026 that may be closed by this pull request
Implement caching of LS Login public key for verifying LS login tokens in the Proxy service #686
Open
@joshbaskaran joshbaskaran changed the title feat: add oauth2 resource server dependency fix: fixes calls to LS login server per request Jan 16, 2026
@joshbaskaran joshbaskaran self-assigned this Jan 16, 2026
@joshbaskaran joshbaskaran requested a review from kjellp January 16, 2026 15:05
kjellp
kjellp reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

@kjellp kjellp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far to me. Do we implement testing of the feature here? And make cache expire time configurable?

@joshbaskaran
Copy link
Contributor Author

joshbaskaran commented Jan 19, 2026

Looks good so far to me. Do we implement testing of the feature here? And make cache expire time configurable?

I can make it configurable here, but I think the test should be a separate thing that's better done at the e2e scope.

@joshbaskaran joshbaskaran force-pushed the 686-implement-caching-of-ls-login branch from d17d2dd to a715e90 Compare January 19, 2026 07:29
@joshbaskaran joshbaskaran requested a review from kjellp January 19, 2026 08:24
@dependabot
[e2eTests]: bump org.postgresql:postgresql
c3b9a53 
Bumps the all-modules group in /e2eTests with 1 update: [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc).


Updates `org.postgresql:postgresql` from 42.7.8 to 42.7.9
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](pgjdbc/pgjdbc@REL42.7.8...REL42.7.9)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-version: 42.7.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
...

Signed-off-by: dependabot[bot] <[email protected]>
@joshbaskaran joshbaskaran changed the title fix: fixes calls to LS login server per request fix(localega-tsd-proxy): fixes calls to LS login per request Jan 19, 2026
@kjellp kjellp force-pushed the 686-implement-caching-of-ls-login branch from a715e90 to b222abe Compare January 19, 2026 10:35
@kjellp
Copy link
Contributor

kjellp commented Jan 19, 2026

Excellent with that quick update to make caching parameters configurable @joshbaskaran :)

To include it at e2e level testing is an option, but was unsure if it really belonged there, as this may become a "costly" test, and belong more at build level, than for every e2e test run for any change of the mono-repo in the future?

But for now we can aim at test it manually on egadev with an e2e run there (using live LS-login tokens), before we approve and merge it. We need to design how to test it, with both positive and negative tests though.

@joshbaskaran
Copy link
Contributor Author

joshbaskaran commented Jan 19, 2026

Excellent with that quick update to make caching parameters configurable @joshbaskaran :)

To include it at e2e level testing is an option, but was unsure if it really belonged there, as this may become a "costly" test, and belong more at build level, than for every e2e test run for any change of the mono-repo in the future?

But for now we can aim at test it manually on egadev with an e2e run there (using live LS-login tokens), before we approve and merge it. We need to design how to test it, with both positive and negative tests though.

Thanks! :)
E2e is indeed quite costly. I might be able to write a rudimentary test to see how many HTTP calls to the OIDC server are made on multiple requests. I'll look a bit more into this!

Parisa68 and others added 12 commits January 19, 2026 12:11
@Parisa68
Merge pull request #692 from ELIXIR-NO/dependabot/gradle/e2eTests/all…
d64be22 
…-modules-0f8b47c86f

[e2eTests]: bump org.postgresql:postgresql from 42.7.8 to 42.7.9 in /e2eTests in the all-modules group
@kjetilkl @kjellp
test(crypt4gh): Add test for edit list with an odd number of values
75b2948
@kjetilkl @kjellp
fix(crypt4gh): Correct the application of edit lists containing an od…
4de4a87 
…d number of values

If an edit list contains an odd number of values, meaning the last value
is the length of a segment that should be excluded, then the rest of the file
after that should be implicitly included (according to the Crypt4GH specification).
This does not happen in our current implementation.

This commit fixes that issue, and ensures that the rest of the file after
the last exclusion is included in the final output.
@kjetilkl @kjellp
test(crypt4gh): Cleanup unnecessary code
a6b785b
@kjetilkl @kjellp
test(crypt4gh): Add test for odd-numbered edit list with forward skip…
b0ed14c 
…ping

The test applies an edit list with an odd number of values to the decrypted stream,
which excludes three segments and implicitly includes the rest of the stream
in the final output. It also performs two forward skips in the edited stream,
where the second of these end up in the implicitly included segment.
@kjellp
Merge pull request #683 from ELIXIR-NO/fix/crypt4gh_edit_lists
7d50d45 
fix(crypt4gh): Correct the application of edit lists containing an odd number of values
@Parisa68
[feat] group related modules in one update
2e7a5fc
@Parisa68
Merge pull request #694 from ELIXIR-NO/feature/grouping-modules
4eebab3 
[feat] group related modules in one update
@Parisa68
[refactor] remove jackson dependency
02cd6b9
@Parisa68
[refactor] use jackson3 objectMapper
d914016
@Parisa68
[refactor] replace deprecated methods
78e04e6
@Parisa68
Merge pull request #695 from ELIXIR-NO/refactor/remove-redundent-dep
3ecb4ff 
Migrating from jackson 2 to 3 in tsd api mock
dependabot bot and others added 13 commits January 22, 2026 10:07
@dependabot
[Java]: Bump the all-modules group across 2 directories with 6 updates
5edff8a 
Bumps the all-modules group with 3 updates in the /lib/clearinghouse directory: [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit-framework), [org.junit.platform:junit-platform-launcher](https://github.com/junit-team/junit-framework) and [io.freefair.lombok](https://github.com/freefair/gradle-plugins).
Bumps the all-modules group with 3 updates in the /lib/crypt4gh directory: [io.freefair.lombok](https://github.com/freefair/gradle-plugins), [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit-framework) and [com.gradleup.shadow](https://github.com/GradleUp/shadow).


Updates `org.junit.jupiter:junit-jupiter-api` from 6.0.1 to 6.0.2
- [Release notes](https://github.com/junit-team/junit-framework/releases)
- [Commits](junit-team/junit-framework@r6.0.1...r6.0.2)

Updates `org.junit.jupiter:junit-jupiter-engine` from 6.0.1 to 6.0.2
- [Release notes](https://github.com/junit-team/junit-framework/releases)
- [Commits](junit-team/junit-framework@r6.0.1...r6.0.2)

Updates `org.junit.platform:junit-platform-launcher` from 6.0.1 to 6.0.2
- [Release notes](https://github.com/junit-team/junit-framework/releases)
- [Commits](junit-team/junit-framework@r6.0.1...r6.0.2)

Updates `io.freefair.lombok` from 9.1.0 to 9.2.0
- [Release notes](https://github.com/freefair/gradle-plugins/releases)
- [Commits](freefair/gradle-plugins@9.1.0...9.2.0)

Updates `io.freefair.lombok` from 9.1.0 to 9.2.0
- [Release notes](https://github.com/freefair/gradle-plugins/releases)
- [Commits](freefair/gradle-plugins@9.1.0...9.2.0)

Updates `io.freefair.lombok` from 9.1.0 to 9.2.0
- [Release notes](https://github.com/freefair/gradle-plugins/releases)
- [Commits](freefair/gradle-plugins@9.1.0...9.2.0)

Updates `org.junit.jupiter:junit-jupiter` from 6.0.1 to 6.0.2
- [Release notes](https://github.com/junit-team/junit-framework/releases)
- [Commits](junit-team/junit-framework@r6.0.1...r6.0.2)

Updates `io.freefair.lombok` from 9.1.0 to 9.2.0
- [Release notes](https://github.com/freefair/gradle-plugins/releases)
- [Commits](freefair/gradle-plugins@9.1.0...9.2.0)

Updates `com.gradleup.shadow` from 9.3.0 to 9.3.1
- [Release notes](https://github.com/GradleUp/shadow/releases)
- [Commits](GradleUp/shadow@9.3.0...9.3.1)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
- dependency-name: org.junit.jupiter:junit-jupiter-engine
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
- dependency-name: org.junit.platform:junit-platform-launcher
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
- dependency-name: io.freefair.lombok
  dependency-version: 9.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-modules
- dependency-name: io.freefair.lombok
  dependency-version: 9.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-modules
- dependency-name: io.freefair.lombok
  dependency-version: 9.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-modules
- dependency-name: org.junit.jupiter:junit-jupiter
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
- dependency-name: io.freefair.lombok
  dependency-version: 9.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-modules
- dependency-name: com.gradleup.shadow
  dependency-version: 9.3.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
...

Signed-off-by: dependabot[bot] <[email protected]>
@Parisa68
Merge pull request #702 from ELIXIR-NO/dependabot/gradle/lib/clearing…
1838384 
…house/all-modules-c18dfd0f8f

[Java]: Bump the all-modules group across 2 directories with 6 updates
@Parisa68 @kjellp
[feature] group updates for docker
cb38b07
@kjellp
Merge pull request #701 from ELIXIR-NO/feature/add-grouping-docker-up…
2c913bc 
…dates

[feature] group updates for docker
@dependabot
[Go]: Bump github.com/neicnordic/crypt4gh
5c8ce09 
Bumps the all-modules group with 1 update in the /cli/lega-commander directory: [github.com/neicnordic/crypt4gh](https://github.com/neicnordic/crypt4gh).


Updates `github.com/neicnordic/crypt4gh` from 1.14.0 to 1.14.1
- [Release notes](https://github.com/neicnordic/crypt4gh/releases)
- [Commits](neicnordic/crypt4gh@v1.14.0...v1.14.1)

---
updated-dependencies:
- dependency-name: github.com/neicnordic/crypt4gh
  dependency-version: 1.14.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
...

Signed-off-by: dependabot[bot] <[email protected]>
@Parisa68
Merge pull request #697 from ELIXIR-NO/dependabot/go_modules/cli/lega…
b06dc62 
…-commander/all-modules-778b039c27

[Go]: Bump github.com/neicnordic/crypt4gh from 1.14.0 to 1.14.1 in /cli/lega-commander in the all-modules group across 1 directory
@dependabot @Parisa68
[Java]: Bump the all-modules group across 3 directories with 2 updates
8ec4746 
Bumps the all-modules group with 1 update in the /buildSrc directory: [com.diffplug.spotless:spotless-plugin-gradle](https://github.com/diffplug/spotless).
Bumps the all-modules group with 1 update in the /services/localega-tsd-proxy directory: [org.springframework.boot](https://github.com/spring-projects/spring-boot).
Bumps the all-modules group with 1 update in the /services/tsd-api-mock directory: [org.springframework.boot](https://github.com/spring-projects/spring-boot).


Updates `com.diffplug.spotless:spotless-plugin-gradle` from 8.1.0 to 8.2.0
- [Release notes](https://github.com/diffplug/spotless/releases)
- [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md)
- [Commits](diffplug/spotless@gradle/8.1.0...gradle/8.2.0)

Updates `org.springframework.boot` from 4.0.1 to 4.0.2
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v4.0.1...v4.0.2)

Updates `org.springframework.boot` from 4.0.1 to 4.0.2
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v4.0.1...v4.0.2)

---
updated-dependencies:
- dependency-name: com.diffplug.spotless:spotless-plugin-gradle
  dependency-version: 8.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-modules
- dependency-name: org.springframework.boot
  dependency-version: 4.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
- dependency-name: org.springframework.boot
  dependency-version: 4.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-modules
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Merge 8ec4746 into b06dc62
d409e31
@actions-user
Code formatting applied
c3e32f6
@Parisa68
Merge pull request #704 from ELIXIR-NO/dependabot/gradle/buildSrc/all…
2194d9b 
…-modules-763e48655a

[Java]: Bump the all-modules group across 3 directories with 2 updates
@joshbaskaran
test: add unit tests for JwtDecoderConfig with caching behavior
999fe47 
Includes WireMock for mocking OIDC calls and validates cache functionality. Added WireMock dependency to build file.
@joshbaskaran
Merge 999fe47 into 2194d9b
361a9fc
@actions-user
Code formatting applied
8cd49e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjellp kjellp Awaiting requested review from kjellp

At least 1 approving review is required to merge this pull request.

Assignees

@joshbaskaran joshbaskaran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement caching of LS Login public key for verifying LS login tokens in the Proxy service

6 participants

@joshbaskaran @kjellp @Parisa68 @kjetilkl @actions-user