Skip to content

add aria-labels #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korbinib merged 2 commits into from
Aug 28, 2025
Merged

add aria-labels #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4dabfc
add aria-labels
korbinib Aug 28, 2025
37f13db
add label dark mode button
korbinib Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export const Navigation = ({ pathname }) => {
<button
type="button"
onClick={() => setMobileMenuOpen(true)}
aria-label="Open main menu"
className="-m-2.5 inline-flex items-center justify-center rounded-md p-2.5 text-gray-700"
>
<span className="sr-only">Open main menu</span>
Expand All @@ -89,7 +90,7 @@ export const Navigation = ({ pathname }) => {
</div>
<div className="hidden lg:flex gap-x-2 lg:flex-1 lg:justify-end">
<ThemeToggle/>
<button onClick={onSearchClick}>
<button onClick={onSearchClick} aria-label="Search">
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" strokeWidth={1.5}
stroke="currentColor" className="size-6">
<path strokeLinecap="round" strokeLinejoin="round"
Expand All @@ -98,7 +99,7 @@ export const Navigation = ({ pathname }) => {
</button>
</div>
</nav>
<Dialog open={mobileMenuOpen} onClose={setMobileMenuOpen} className="lg:hidden">
<Dialog open={mobileMenuOpen} onClose={setMobileMenuOpen} className="lg:hidden" >
<div className="fixed inset-0 z-50"/>
<DialogPanel
className="fixed inset-y-0 right-0 z-50 w-full overflow-y-auto bg-white px-6 py-6 sm:max-w-sm sm:ring-1 sm:ring-gray-900/10">
Expand All @@ -115,6 +116,7 @@ export const Navigation = ({ pathname }) => {
type="button"
onClick={() => setMobileMenuOpen(false)}
className="flex items-center justify-center"
aria-label="Close menu"
>
<span className="sr-only">Close menu</span>
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24"
Expand Down
4 changes: 2 additions & 2 deletions src/components/theme-toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function ThemeToggle() {
};

return (
<button onClick={onClick} className="h-8 w-8 p-0.5 hover:scale-110">
<button onClick={onClick} className="h-8 w-8 p-0.5 hover:scale-110" aria-label="Toggle Dark/Light Mode">
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" strokeWidth={1.5}
stroke="currentColor" className="size-6 block dark:hidden">
<path strokeLinecap="round" strokeLinejoin="round"
Expand All @@ -22,4 +22,4 @@ export default function ThemeToggle() {
</button>
);

}
}