-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/statistics #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
968e729
trying a benchmark
qchapp 7da36b4
fixed stats
qchapp 3e1a9bc
small test
qchapp a1386f7
testing something
qchapp 5181248
slurm config
qchapp 4af933d
display issue with multiple nodes
qchapp 5398ab2
small test again
qchapp aafb230
trying again
qchapp 79ca2fe
excluding cold start
qchapp 3ba5c97
now same for gpu
qchapp 19d7d8a
small corrections
qchapp 0a46d7d
ready for PR
qchapp 716f7b3
Potential fix for pull request finding
qchapp 3218285
Potential fix for pull request finding
qchapp 1f0b9e0
copilot suggestions
qchapp cb1cc3c
Potential fix for pull request finding
qchapp 26eeea1
Potential fix for pull request finding
qchapp dc1c966
function deduplication
qchapp 1ef07d4
Potential fix for pull request finding
qchapp dfa7fae
copilot changes
qchapp 7946278
implemented changes requested by fabrice
qchapp c962618
fixed TokenCounts logic
fabnemEPFL fdb0d42
fixed various typing and logic errors
fabnemEPFL 37ca65a
fixed image base path
fabnemEPFL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # MMIRAGE — DataTrove-compatible throughput benchmark | ||
| # See README.md for setup instructions and benchmark details. | ||
|
|
||
| processors: | ||
| - type: llm | ||
| server_args: | ||
| model_path: Qwen/Qwen3-4B # same model family as DataTrove baseline | ||
| tp_size: 1 # DataTrove baseline: tp=1 | ||
| trust_remote_code: true | ||
| disable_custom_all_reduce: true | ||
| # SGLang engine tuning — equivalents of DataTrove's vLLM mns/mnbt knobs | ||
| extra_engine_args: | ||
| max_running_requests: 1000 | ||
| default_sampling_params: | ||
| temperature: 0.0 | ||
| max_new_tokens: 1024 # DataTrove: max-tokens=1024 | ||
|
|
||
| loading_params: | ||
| state_dir: data/benchmark_s1k/_pipeline_state | ||
| datasets: | ||
| - path: data/s1K-1.1 # save_to_disk() target above | ||
| type: loadable | ||
| output_dir: data/benchmark_s1k/output | ||
| num_shards: 1 | ||
| shard_id: "$SLURM_ARRAY_TASK_ID" | ||
| batch_size: 1000 | ||
|
|
||
| processing_params: | ||
| inputs: | ||
| - name: question | ||
| key: question # DataTrove: prompt-column=question | ||
|
|
||
| outputs: | ||
| - name: answer | ||
| type: llm | ||
| output_type: plain | ||
| # Qwen3 thinking is disabled by embedding an empty <think> block in the prompt. | ||
| # This is equivalent to passing enable_thinking=False to the chat template and | ||
| # avoids any dependency on SGLang sampling-param support for that flag. | ||
| prompt: "<|im_start|>user\n{{ question }}\n<|im_end|>\n<|im_start|>assistant\n<think>\n\n</think>\n" | ||
|
|
||
| remove_columns: false | ||
| output_schema: | ||
| question: "{{ question }}" | ||
| answer: "{{ answer }}" | ||
|
|
||
| execution_params: | ||
| mode: slurm | ||
| retry: false | ||
| merge: false | ||
| max_retries: 3 | ||
| account: a127 | ||
| job_name: mmirage-sharded | ||
| nodes: 1 | ||
| ntasks_per_node: 1 | ||
| gpus: 1 | ||
| cpus_per_task: 288 | ||
| time_limit: "11:59:59" | ||
| report_dir: "/users/${USER}/reports" | ||
| hf_home: "/capstor/store/cscs/swissai/a127/homes/${USER}/hf" | ||
| edf_env: "/users/${USER}/.edf/mmirage.toml" | ||
| poll_interval_seconds: 30 | ||
| settle_time_seconds: 60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.