Skip to content

Fix docker configurations#44

Merged
fabnemEPFL merged 11 commits into
EPFLiGHT:mainfrom
JCHAVEROT:fix/docker
May 12, 2026
Merged

Fix docker configurations#44
fabnemEPFL merged 11 commits into
EPFLiGHT:mainfrom
JCHAVEROT:fix/docker

Conversation

@JCHAVEROT
Copy link
Copy Markdown

@JCHAVEROT JCHAVEROT commented May 12, 2026

Summary

Related issue: #22
Depending on: #30

  • Miscellaneous corrections following code review on Fix Docker deployment #30 and tests on RCP cluster to ensure all pipelines are running correctly
  • Workflow changes with migration from DockerHub to GHCR for the images push (you can have a look at the new CI using this link, and at the built docker images using this link)

@JCHAVEROT JCHAVEROT self-assigned this May 12, 2026
@JCHAVEROT JCHAVEROT added bug Something isn't working documentation Improvements or additions to documentation labels May 12, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts MMIRAGE’s Docker setup and related documentation/CI to support updated image building/publishing (migrating from DockerHub to GHCR) and to refine install/Docker usage instructions.

Changes:

  • Update Docker build/publish GitHub Actions workflow to target GHCR and build multi-arch CPU images.
  • Update Dockerfiles (GPU/CPU) and README Docker usage instructions.
  • Pin sglang GPU extra dependency to a specific version.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
README.md Updates install instructions and Docker/GHCR usage guidance.
pyproject.toml Pins the sglang GPU extra version.
docker/Dockerfile.cpu Changes CPU image entrypoint behavior.
docker/Dockerfile Pins GPU base image tag and changes entrypoint behavior.
.github/workflows/docker.yml Migrates image publishing from DockerHub to GHCR and introduces metadata-based tagging + multi-arch builds.
Comments suppressed due to low confidence (1)

pyproject.toml:47

  • The GPU optional dependency pins sglang==0.5.10, but the GPU Docker image is based on lmsysorg/sglang:v0.5.3rc1-cu126. This version skew can lead to runtime/API incompatibilities or pip attempting to replace the preinstalled SGLang. Consider aligning the base image tag with the Python dependency version (or loosening/pinning them consistently).
[project.optional-dependencies]
gpu = [
  "sglang==0.5.10",
  "sgl_kernel",
  "xgrammar",
  "compressed_tensors",
]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/docker.yml
Comment thread .github/workflows/docker.yml
Comment thread .github/workflows/docker.yml
Comment thread docker/Dockerfile
Comment thread docker/Dockerfile.cpu
Comment thread README.md
Comment thread README.md
@fabnemEPFL fabnemEPFL merged commit 7bf68d2 into EPFLiGHT:main May 12, 2026
4 checks passed
@JCHAVEROT JCHAVEROT deleted the fix/docker branch May 12, 2026 14:51
@JCHAVEROT JCHAVEROT linked an issue May 12, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the docker deployment

3 participants