Fix docker configurations#44
Merged
Merged
Conversation
fabnemEPFL
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts MMIRAGE’s Docker setup and related documentation/CI to support updated image building/publishing (migrating from DockerHub to GHCR) and to refine install/Docker usage instructions.
Changes:
- Update Docker build/publish GitHub Actions workflow to target GHCR and build multi-arch CPU images.
- Update Dockerfiles (GPU/CPU) and README Docker usage instructions.
- Pin
sglangGPU extra dependency to a specific version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Updates install instructions and Docker/GHCR usage guidance. |
pyproject.toml |
Pins the sglang GPU extra version. |
docker/Dockerfile.cpu |
Changes CPU image entrypoint behavior. |
docker/Dockerfile |
Pins GPU base image tag and changes entrypoint behavior. |
.github/workflows/docker.yml |
Migrates image publishing from DockerHub to GHCR and introduces metadata-based tagging + multi-arch builds. |
Comments suppressed due to low confidence (1)
pyproject.toml:47
- The GPU optional dependency pins
sglang==0.5.10, but the GPU Docker image is based onlmsysorg/sglang:v0.5.3rc1-cu126. This version skew can lead to runtime/API incompatibilities or pip attempting to replace the preinstalled SGLang. Consider aligning the base image tag with the Python dependency version (or loosening/pinning them consistently).
[project.optional-dependencies]
gpu = [
"sglang==0.5.10",
"sgl_kernel",
"xgrammar",
"compressed_tensors",
]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #22
Depending on: #30