ci: create production-config with environment variables#128
Merged
Conversation
…HT#130) * better default config file for processing * removed useless run_index.load_results * stop processing if crawl_result is empty * removed useless import
* better default config file for processing * removed useless run_index.load_results * stop processing if crawl_result is empty * removed useless import * fix to make sure samples are extracted from exisiting files
…n into refacto-deployment
fabnemEPFL
approved these changes
Jul 16, 2025
fabnemEPFL
left a comment
fabnemEPFL
left a comment
Collaborator
There was a problem hiding this comment.
All good, great job! 🔥
JCHAVEROT
pushed a commit
to JCHAVEROT/mmore
that referenced
this pull request
Jun 19, 2026
* ci: create production-config with environment variables * temporarily change ids * No crash if the processor is asked to process an empty folder (EPFLiGHT#130) * better default config file for processing * removed useless run_index.load_results * stop processing if crawl_result is empty * removed useless import * Fix of Accept empty folder (EPFLiGHT#133) * better default config file for processing * removed useless run_index.load_results * stop processing if crawl_result is empty * removed useless import * fix to make sure samples are extracted from exisiting files * create retriever api config * run in virtual env * use pip instead of uv * clean up dockerfile * add caching to github actions * create two images every time * use libs in dockerfile * fix image tag on dockerhub * woops, pip no longer support system * fix dockerfile by adding source code before pip and use uv * fix dockerfile perms again * mixed up gid and uid... * run format --------- Co-authored-by: fabnemEPFL <117652591+fabnemEPFL@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ROOT_OUT_DIR,$ROOT_IN_DIRenvironment variables so we can now easily specify a different storage path without having to changes prodution configuration files (added in a newproduction-configfolder). Once we deploy to production, I will write down everything (see add documentation for production once it's ready #136).