Skip to content

[Logs] Fix output for tasks in logs #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

joligario
Copy link
Contributor

Description

Fixes an issue where the wrong NPC ID and NPC Name were exported during TASK_ACCEPT. The NPC ID was actually the NPC Entity ID and the NPC Name was the player's name.
image
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Individual task data correctly exported:
image

Shared task data correctly exported:
image

Both standard and shared tasks accepted and loaded:
image

Clients tested: RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@joligario joligario marked this pull request as ready for review May 26, 2025 04:37
@Akkadius Akkadius requested a review from hgtw May 26, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants