Skip to content

Conversation

@galabovaa
Copy link
Contributor

No description provided.

filikat and others added 30 commits July 15, 2025 11:52
…being solved if a specific LP solver is chosen; Highs::presolve() now presolves the relaxation if solve_relaxation is true; Analytic centre calculation now sets option solve_relaxation, otherwise it solves the MIP (recursively\!)
@galabovaa galabovaa requested review from filikat and jajhall October 21, 2025 14:15
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 88.21138% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.11%. Comparing base (45df09a) to head (8908815).
⚠️ Report is 283 commits behind head on latest.

Files with missing lines Patch % Lines
highs/util/HighsTimer.h 31.42% 24 Missing ⚠️
highs/mip/HighsMipSolverData.cpp 56.75% 16 Missing ⚠️
highs/mip/HighsMipAnalysis.cpp 84.04% 15 Missing ⚠️
highs/lp_data/HighsSolve.cpp 85.00% 9 Missing ⚠️
highs/mip/HighsLpRelaxation.cpp 89.77% 9 Missing ⚠️
highs/lp_data/HighsOptions.h 72.22% 5 Missing ⚠️
check/TestIpm.cpp 71.42% 2 Missing ⚠️
highs/ipm/IpxWrapper.cpp 90.90% 2 Missing ⚠️
highs/lp_data/HighsOptions.cpp 94.44% 2 Missing ⚠️
highs/lp_data/Highs.cpp 98.07% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2583      +/-   ##
==========================================
+ Coverage   79.78%   81.11%   +1.33%     
==========================================
  Files         346      347       +1     
  Lines       86599    87145     +546     
==========================================
+ Hits        69090    70690    +1600     
+ Misses      17509    16455    -1054     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly I can't comment on all the build changes, or the HiPO source, so there's not much left beyond what I wrote to accommodate HiPO in options, Highs::optimizeModel and unit tests.

Has the (default) use of HiPO for the analytic centre calculation been tested by @fwesselm? I'm not sure I've tested it on large numbers of MIPs - just the energy MIPs. At this stage pre-release, I think it's safer to keep IPX as the default

@fwesselm
Copy link
Collaborator

Clearly I can't comment on all the build changes, or the HiPO source, so there's not much left beyond what I wrote to accommodate HiPO in options, Highs::optimizeModel and unit tests.

Has the (default) use of HiPO for the analytic centre calculation been tested by @fwesselm? I'm not sure I've tested it on large numbers of MIPs - just the energy MIPs. At this stage pre-release, I think it's safer to keep IPX as the default

No, I have not tested this. Let me know and I can try this.

@jajhall
Copy link
Member

jajhall commented Oct 22, 2025

No, I have not tested this. Let me know and I can try this.

Thanks. For now the MIP solver won't use HiPO by default. There's no reason why it should fail - and it's backed up by a call to IPX, but using HiPO will lead to a random change in MIP solver behaviour

@galabovaa galabovaa merged commit 2d57315 into latest Oct 22, 2025
376 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants