Skip to content

Conversation

@Opt-Mucca
Copy link
Collaborator

I noticed this while trying to debug something else. I believe we're simply using the wrong index in a check (luckily the index can never be out of range so it will never fail a test). Specifically, we're checking the propagatecutflags_[k], where k is the index looping over a subset of cuts we want to propagate, while we should be checking propagatecutflags[propagateinds[k]], i.e., the actual index of the cut being checked. Current behavior means we could be skipping propagation of some cut because a cut at another index has been deleted.

@fwesselm The propagation code is headache inducing, so I'd appreciate a second set of eyes checking this.

@Opt-Mucca Opt-Mucca requested a review from fwesselm December 4, 2025 11:29
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (263398e) to head (4d0fc37).
⚠️ Report is 10 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2679   +/-   ##
=======================================
  Coverage   81.26%   81.27%           
=======================================
  Files         349      349           
  Lines       85779    85779           
=======================================
+ Hits        69707    69713    +6     
+ Misses      16072    16066    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fwesselm fwesselm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @Opt-Mucca! Looks good!

@Opt-Mucca Opt-Mucca merged commit cd819df into latest Dec 4, 2025
390 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants