Check correct index for skipping cut propagation #2679
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while trying to debug something else. I believe we're simply using the wrong index in a check (luckily the index can never be out of range so it will never fail a test). Specifically, we're checking the
propagatecutflags_[k], wherekis the index looping over a subset of cuts we want to propagate, while we should be checkingpropagatecutflags[propagateinds[k]], i.e., the actual index of the cut being checked. Current behavior means we could be skipping propagation of some cut because a cut at another index has been deleted.@fwesselm The propagation code is headache inducing, so I'd appreciate a second set of eyes checking this.