Skip to content

Conversation

@peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Oct 23, 2025

Tag name (required for release branches): TBD
Originator(s): peverwhee

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

  • initialize needed host model variables
  • modify runtime_obj to include name of dycore
  • calculate coszrs to be used by radiation (and add namelist variables needed for this)
    • only calculate if we're not using snapshots
  • update registry generation code to check initial values vs use statements
  • add test

Describe any changes made to build system:

Describe any changes made to the namelist:

List any changes to the defaults for the input datasets (e.g. boundary datasets):

List all files eliminated and why:

List all files added and what they do:

A cime_config/testdefs/testmods_dirs/cam/outfrq_rrtmgp_derecho/shell_commands
A cime_config/testdefs/testmods_dirs/cam/outfrq_rrtmgp_derecho/user_nl_cam
A cime_config/testdefs/testmods_dirs/cam/outfrq_rrtmgp_derecho/user_nl_cpl

  • rrtmgp test mods

A src/utils/machine.F90

  • add for NOAA portability

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M .gitmodules

  • update framework tag and atmospheric physics hash

M ccpp_framework
M src/physics/ncar_ccpp

  • update submodules

M cime_config/namelist_definition_cam.xml
M src/control/runtime_opts.F90
M src/physics/utils/radiation_namelist.F90
M src/physics/utils/radiation_namelist.meta

  • add radiation NL

M cime_config/testdefs/testlist_cam.xml

  • add rrtmgp test

M src/control/cam_comp.F90
M src/control/cam_control_mod.F90

  • initialize host-model variables needed by rrtmgp

M src/control/runtime_obj.F90
M src/control/runtime_obj.meta
M src/dynamics/mpas/dyn_comp_impl.F90
M src/dynamics/none/dyn_comp.F90
M src/dynamics/se/dyn_comp.F90

  • Modify runtime obj to include dycore name

M src/data/generate_registry_data.py

  • check initial value vs use statements

M src/data/registry.xml

  • add necessary host model variables

M src/data/registry_v1_0.xsd

  • allow capital letters in std name (constituent names)

M src/physics/utils/orbital_data.F90

  • conditionally calculate coszrs for radiation

M test/unit/python/sample_files/*

  • update tests

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:
All tests NLFAIL due to new radiation namelist fields

derecho/gnu/aux_sima:
SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_rrtmgp_derecho (Overall: DIFF)

  • new test/baseline

All other tests NLFAIL due to new radiation namelist fields

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced: n/a

CAM-SIMA date used for the baseline comparison tests if different than latest:

Courtney Peverley and others added 30 commits June 6, 2025 11:12
@peverwhee peverwhee requested a review from nusbaume October 23, 2025 22:29
@peverwhee peverwhee self-assigned this Oct 23, 2025
@peverwhee peverwhee removed the request for review from nusbaume October 23, 2025 22:30
@peverwhee peverwhee marked this pull request as draft October 23, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants