cam6_4_042: Fix reference pressures for MPAS #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
approved these changes
Oct 21, 2024
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Went ahead and made the modifications I was going to request during code review, so everything looks good to me now. Thanks!
cacraigucar
changed the title
kuanchihwang
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Nov 8, 2024
…dynamical core (#317) ### Tag name (required for release branches): None ### Originator(s): PeterHjortLauritzen, nusbaume, kuanchihwang ### Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): Presently, MPAS dynamical core is not initializing reference pressure for physics in the same way as others. This PR backports the fix from ESCOMP/CAM#1169. To confirm the fix, observe log entries similar to the following in `atm.log.<job-id>.<date>-<time>`. The reference pressure at surface now starts from 1000 hPa. Previously, it starts from 1013.25 hPa. ``` dyn_debug_print (0): Reference layer information: dyn_debug_print (0): ----- | -------------- | -------------- dyn_debug_print (0): Index | Height (m) | Pressure (hPa) dyn_debug_print (0): ----- | 44999.999819 | 1.431394 dyn_debug_print (0): 1 | 43953.595504 | 1.655836 dyn_debug_print (0): ----- | 42907.191189 | 1.880278 dyn_debug_print (0): 2 | 41877.531046 | 2.177235 dyn_debug_print (0): ----- | 40847.870904 | 2.474192 dyn_debug_print (0): 3 | 39835.232205 | 2.867591 dyn_debug_print (0): ----- | 38822.593507 | 3.260989 ... (SNIPPED) ... dyn_debug_print (0): ----- | 1292.109873 | 856.014954 dyn_debug_print (0): 30 | 997.820649 | 887.686997 dyn_debug_print (0): ----- | 703.531425 | 919.359041 dyn_debug_print (0): 31 | 476.271636 | 945.093654 dyn_debug_print (0): ----- | 249.011847 | 970.828267 dyn_debug_print (0): 32 | 124.505924 | 985.414133 dyn_debug_print (0): ----- | 0.000000 | 1000.000000 ``` Closes #315. ### Describe any changes made to build system: None ### Describe any changes made to the namelist: None ### List any changes to the defaults for the input datasets (e.g. boundary datasets): None ### List all files eliminated and why: None ### List all files added and what they do: None ### List all existing files that have been modified, and describe the changes: * `M src/dynamics/mpas/dyn_comp.F90` * Sort statements * `M src/dynamics/mpas/dyn_grid.F90` * Properly call `std_atm_pres` to initialize reference pressure for physics * Wire up history support * More explicit memory management * Update code comments * `M src/utils/std_atm_profile.F90` * Allow custom surface pressure in `std_atm_pres` * Remove unused variable in `std_atm_pres` --------- Co-authored-by: Peter Hjort Lauritzen <[email protected]> Co-authored-by: Jesse Nusbaumer <[email protected]>
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 13, 2025
Merge pull request ESCOMP#1169 from PeterHjortLauritzen/std_atm_fix_for_mpas cam6_4_042: Fix reference pressures for MPAS ESCOMP commit: ddacf0f
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 19, 2025
Merge pull request ESCOMP#1169 from PeterHjortLauritzen/std_atm_fix_for_mpas cam6_4_042: Fix reference pressures for MPAS ESCOMP commit: ddacf0f
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 23, 2025
Merge pull request ESCOMP#1169 from PeterHjortLauritzen/std_atm_fix_for_mpas cam6_4_042: Fix reference pressures for MPAS ESCOMP commit: ddacf0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in #1168
This PR closes #1168