cam6_4_075: Clean up (all SE dycore) plus other misc #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@PeterHjortLauritzen - was this PR closed intentionally without being merged in? If so, could you please give a comment on why you are doing so? |
Collaborator
Author
I renamed branch (apparently one can not do that with an open PR) ... |
PeterHjortLauritzen
changed the title
nusbaume
approved these changes
Feb 20, 2025
cacraigucar
changed the title
cacraigucar
changed the title
cacraigucar
changed the title
cacraigucar
changed the title
cacraigucar
changed the title
cacraigucar
changed the title
…amelist defaults check.
cacraigucar
added a commit
to nusbaume/CAM
that referenced
this pull request
Mar 13, 2025
Merge pull request ESCOMP#1214 from PeterHjortLauritzen/clean-up-bugfix
cacraigucar
added a commit
to cacraigucar/CAM
that referenced
this pull request
Mar 13, 2025
Merge pull request ESCOMP#1214 from PeterHjortLauritzen/clean-up-bugfix
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Apr 14, 2025
Merge pull request ESCOMP#1214 from PeterHjortLauritzen/clean-up-bugfix cam6_4_075: Clean up (all SE dycore) plus other misc ESCOMP commit: e73a79b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the merge of the SE dycore in CAM-SIMA I discovered nudging variables being allocated and never used (many of these were 3D variables). These have been removed.
Some other minor clean-up as well.
This PR also includes the changes in PRs #1016, #1255, #1266, and #1269.
Resolves #844
Resolves #819
Resolves #1250
Resolves #1254