Skip to content
Merged
Show file tree
Hide file tree
Changes from 47 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
83e905c
gwccpp1 changes
jtruesdal Feb 19, 2025
fe2e06b
cam6_4_047 update
jtruesdal Feb 19, 2025
6e0b83f
trial commit for merge up to 90
jtruesdal May 5, 2025
274e6b8
init gw mods for vsc
jtruesdal Jul 12, 2025
9931db5
fixes for new io reader, added src/utils/cam_ccpp/pio_reader.F90 and…
jtruesdal Jul 30, 2025
39aeaca
fix bug in ttend_sh declaration and add the diagnostic templates for…
jtruesdal Jul 30, 2025
225de3f
Fix runtime errors -- batch 1
jimmielin Aug 5, 2025
7ec0615
Continue cleanup; add interstitials; vramp to state
jimmielin Aug 6, 2025
b9b5d87
Lift up gw_rdg io to host model level
jimmielin Aug 7, 2025
22b1f7d
Revert some (not all) of extra changes to minimize diffs with ESCOMP/CAM
jimmielin Aug 8, 2025
b0bc529
Further cleanup; add diag addflds following up on previous work
jimmielin Aug 8, 2025
537252e
Continue cleanup; move moving mountains to separate CCPP scheme
jimmielin Aug 8, 2025
71c378c
Update submodule for testing
jimmielin Aug 8, 2025
b4b388a
Improve robustness of ttend_dp handling
jimmielin Aug 8, 2025
e8fc885
Refactor convective drag to separate CCPP schemes.
jimmielin Aug 12, 2025
9630bec
CCPPize gw_oro -> gravity_wave_drag_orographic
jimmielin Aug 12, 2025
fdbc84b
CCPPized Beres/convect; frontogenesis/igw; write diagnostics; remove …
jimmielin Aug 14, 2025
6e1a939
Add missing diagnostics
jimmielin Aug 14, 2025
731cd7a
Reorganize modules
jimmielin Aug 15, 2025
dc0bc5b
Remove gw_drag.F90 in atmos_phys now using gw_common for inti.
jimmielin Aug 15, 2025
1f84dd7
Reorder comment; fix typos in namelist_definition.xml
jimmielin Aug 15, 2025
b3f9205
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Aug 20, 2025
a7d1298
Revert extraneous changes; updates to gw_common call
jimmielin Aug 20, 2025
91b2a9a
Remove pio_reader copies.
jimmielin Aug 20, 2025
37ed969
Fix bugs found by Izumi/Nag.
jimmielin Aug 20, 2025
c1c257a
Update gw_dc_long
jimmielin Aug 25, 2025
3de8911
cleanup; depointerize vramp
jimmielin Aug 26, 2025
2593ff3
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Aug 26, 2025
813e062
Fix pointer corruption problems; output to pcols to fix output issues.
jimmielin Aug 28, 2025
b7333ac
Misc cleanup; movmtn diagnostics for CAM
jimmielin Aug 28, 2025
05b711e
Update mxdisg logic
jimmielin Aug 28, 2025
d8d7922
Remove unused namelist param
jimmielin Aug 28, 2025
111096d
Simplify backward compat interface for ridge as i/o will be done at h…
jimmielin Aug 29, 2025
960886c
Ridge interface init update; update gwx to pcols
jimmielin Sep 5, 2025
3fbe820
Ridge interface init update (2)
jimmielin Sep 9, 2025
a14663e
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Sep 9, 2025
a6b064e
Split off Beres shallow/deep init
jimmielin Sep 19, 2025
9d96da8
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Sep 19, 2025
5c27c03
Separate front and front_igw init in atmos_phys
jimmielin Sep 23, 2025
7e54273
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Sep 23, 2025
246a3bd
Rename directory for gravity_wave_drag.
jimmielin Sep 26, 2025
0e34f0e
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Sep 26, 2025
6539de5
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Oct 1, 2025
cb716e3
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Oct 12, 2025
a072707
Pass in pi to gw_common initialization
jimmielin Oct 13, 2025
eb13f06
Pass top taper to gw scheme and compute within ref_pres.
jimmielin Oct 13, 2025
61f1046
Add pverp to common and convective gw schemes.
jimmielin Oct 14, 2025
b9fd04d
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Oct 27, 2025
6ace641
Address review comments; remove unused subs; check errflg throughout
jimmielin Oct 27, 2025
3e320de
Modernize namelist read; fix errflg check
jimmielin Oct 27, 2025
4452e48
Change pver+1 to pverp throughout in gw_drag_cam
jimmielin Oct 27, 2025
601922b
Update interface init
jimmielin Oct 27, 2025
078940b
Remove save from gw_drag_cam; remove commented out code
jimmielin Oct 27, 2025
72a184c
Update src/physics/cam/gw_drag_cam.F90
jimmielin Oct 28, 2025
e1ae30f
Address review comments
jimmielin Oct 28, 2025
63c1e56
Merge branch 'cam_development' into hplin/gw_drag
jimmielin Nov 27, 2025
cb709ae
Update atmos_phys to atmos_phys0_19_000.
jimmielin Nov 28, 2025
b67a4c4
Finalize ChangeLog for cam6_4_133.
jimmielin Nov 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
url = https://github.com/ESCOMP/atmospheric_physics
fxtag = atmos_phys0_18_002
fxrequired = AlwaysRequired
fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics
fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics

[submodule "cam-sima"]
path = src/utils/cam-sima
Expand Down
1 change: 0 additions & 1 deletion bld/build-namelist
Original file line number Diff line number Diff line change
Expand Up @@ -3885,7 +3885,6 @@ if (!$simple_phys) {
add_default($nl, 'use_gw_convect_sh', 'val'=>'.false.');
add_default($nl, 'gw_lndscl_sgh');
add_default($nl, 'gw_oro_south_fac');
add_default($nl, 'gw_limit_tau_without_eff');
add_default($nl, 'gw_apply_tndmax');

# Gravity wave ridge settings
Expand Down
1 change: 1 addition & 0 deletions bld/configure
Original file line number Diff line number Diff line change
Expand Up @@ -2133,6 +2133,7 @@ sub write_filepath
print $fh "$camsrcdir/src/atmos_phys/schemes/rrtmgp/utils\n";
print $fh "$camsrcdir/src/atmos_phys/schemes/rasch_kristjansson\n";
print $fh "$camsrcdir/src/atmos_phys/schemes/utilities\n";
print $fh "$camsrcdir/src/atmos_phys/schemes/gravity_wave_drag\n";
print $fh "$camsrcdir/src/atmos_phys/schemes/rayleigh_friction\n";
print $fh "$camsrcdir/src/atmos_phys/schemes/cloud_fraction\n";
print $fh "$camsrcdir/src/atmos_phys/schemes/vertical_diffusion\n";
Expand Down
14 changes: 3 additions & 11 deletions bld/namelist_files/namelist_defaults_cam.xml
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@
<bnd_topo hgrid="C192" >atm/cam/topo/fv3_C192_nc3000_Co030_Fi001_MulG_PF_Nsw021_c200625.nc</bnd_topo>
<bnd_topo hgrid="C384" >atm/cam/topo/fv3_C384_nc3000_Co015_Fi001_MulG_PF_nullRR_Nsw011_c200625.nc</bnd_topo>

<bnd_topo hgrid="ne3np4" >atm/cam/topo/se/ne3np4_gmted2010_modis_bedmachine_nc0540_Laplace1000_noleak_20230717.nc</bnd_topo>
<bnd_topo hgrid="ne5np4" >atm/cam/topo/se/ne5np4_nc3000_Co360_Fi001_MulG_PF_nullRR_Nsw064_20170515.nc</bnd_topo>
<bnd_topo hgrid="ne16np4" >atm/cam/topo/se/ne16np4_nc3000_Co120_Fi001_PF_nullRR_Nsw084_20171012.nc</bnd_topo>
<bnd_topo hgrid="ne30np4" >atm/cam/topo/se/ne30np4_gmted2010_modis_bedmachine_nc3000_Laplace0100_noleak_greenlndantarcsgh30fac2.50_20250822.nc</bnd_topo>
Expand Down Expand Up @@ -793,6 +794,7 @@

<gw_top_taper>.false.</gw_top_taper>
<gw_top_taper waccmx="1">.true.</gw_top_taper>

<pgwv>32</pgwv>
<pgwv waccmx="1">18</pgwv>

Expand Down Expand Up @@ -857,16 +859,6 @@
<gw_lndscl_sgh chem="trop_strat_mam5_vbsext">.false.</gw_lndscl_sgh>
<gw_lndscl_sgh carma="trop_strat_soa1">.false.</gw_lndscl_sgh>
<gw_lndscl_sgh carma="trop_strat_soa5">.false.</gw_lndscl_sgh>
<gw_limit_tau_without_eff >.false.</gw_limit_tau_without_eff>
<gw_limit_tau_without_eff waccm_phys="1">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff model_top="ht">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff chem="geoschem_mam4">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff chem="trop_strat_mam4_vbs">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff chem="trop_strat_mam4_vbsext">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff chem="trop_strat_mam5_vbs">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff chem="trop_strat_mam5_vbsext">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff carma="trop_strat_soa1">.true. </gw_limit_tau_without_eff>
<gw_limit_tau_without_eff carma="trop_strat_soa5">.true. </gw_limit_tau_without_eff>
<gw_apply_tndmax >.true. </gw_apply_tndmax>
<gw_apply_tndmax chem="geoschem_mam4" >.false.</gw_apply_tndmax>
<gw_apply_tndmax phys="cam7" >.false.</gw_apply_tndmax>
Expand Down Expand Up @@ -2952,7 +2944,7 @@
<scm_relax_tau_top_sec scam="1" > 172800.D0 </scm_relax_tau_top_sec>


<!-- IOP SCAM defaults (The Single Column Atmosphere Model Version 6 (SCAM6), J. Adv. Model. Earth Sy., 11, 13811401, https://doi.org/10.1029/2018MS001578-->
<!-- IOP SCAM defaults (The Single Column Atmosphere Model Version 6 (SCAM6), J. Adv. Model. Earth Sy., 11, 1381-1401, https://doi.org/10.1029/2018MS001578-->

<!-- IOP ARM95/ARM Southern Great Plains/lat:36/lon:263/Jul 1995/18d/M. Zhang et al. (2016)/Land convection -->
<ncdata hgrid="ne3np4" nlev="32" scam_iop="arm95" >atm/cam/inic/se/CESM2.F2000climo.ne3np4.cam.i.0003-06-01-00000.nc</ncdata>
Expand Down
11 changes: 2 additions & 9 deletions bld/namelist_files/namelist_definition.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1270,13 +1270,6 @@ In the low-top model, this helps to conserve momentum and produce a QBO.
Default: set by build-namelist.
</entry>

<entry id="gw_limit_tau_without_eff" type="logical" category="gw_drag"
group="gw_drag_nl" valid_values="" >
Apply limiters to tau before applying the efficiency factor, rather than
afterward.
Default: set by build-namelist
</entry>

<entry id="gw_apply_tndmax" type="logical" category="gw_drag"
group="gw_drag_nl" valid_values="" >
Apply limiter on maximum wind tendency from stress divergence in gravity wave drag scheme.
Expand Down Expand Up @@ -1533,7 +1526,7 @@ Default: set by build-namelist.

<entry id="gw_rdg_do_adjust_tauoro" type="logical" category="gw_rdg"
group="gw_rdg_nl" valid_values="" >
If true, then adujust tauoro
If true, then adjust tauoro
Default: set by build-namelist.
</entry>

Expand Down Expand Up @@ -1575,7 +1568,7 @@ Default: set by build-namelist.

<entry id="gw_rdg_Fr_c" type="real" category="gw_rdg"
group="gw_rdg_nl" valid_values="" >
Critical inverse4 Froude number
Critical inverse Froude number
Default: set by build-namelist.
</entry>

Expand Down
4 changes: 2 additions & 2 deletions src/control/runtime_opts.F90
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ subroutine read_namelist(nlfilename, single_column, scmlat, scmlon)
use hk_conv, only: hkconv_readnl
use uwshcu, only: uwshcu_readnl
use pkg_cld_sediment, only: cld_sediment_readnl
use gw_drag, only: gw_drag_readnl
use gw_drag_cam, only: gw_drag_cam_readnl
use qbo, only: qbo_readnl
use iondrag, only: iondrag_readnl
use waccmx_phys_intr, only: waccmx_phys_ion_elec_temp_readnl
Expand Down Expand Up @@ -157,7 +157,7 @@ subroutine read_namelist(nlfilename, single_column, scmlat, scmlon)
call hkconv_readnl(nlfilename)
call uwshcu_readnl(nlfilename)
call cld_sediment_readnl(nlfilename)
call gw_drag_readnl(nlfilename)
call gw_drag_cam_readnl(nlfilename)
call qbo_readnl(nlfilename)
call lunar_tides_readnl(nlfilename)
call iondrag_readnl(nlfilename)
Expand Down
Loading