Skip to content

Conversation

@mnlevy1981
Copy link
Contributor

Description of changes

In CESM we ran into a funny issue where the ocean component was taking significantly longer to write output at the end of the run than the other components, and somehow the other components convinced the mediator that the model had finished successfully even though the ocean component was still doing stuff. This barrier makes everyone wait to catch up.

Specific notes

Contributors other than yourself, if any: @jedwards4b wrote the code, @gustavo-marques ran it (I have nothing to do with it but Gustavo is on PTO)

CMEPS Issues Fixed (include github issue #): None

Are changes expected to change answers? this should be bfb unless the baseline run did not write out the last MOM6 history file

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed

Gustavo reran some cases where his last monthly history files from MOM6 were not being written out because the mediator was exiting successfully before FMS finished; I believe he verified the 47 months of output he got from both runs were bit-for-bit, plus he got the elusive 48th month of MOM6 output. AFAIK nobody has run any CESM tests with this.

In CESM we ran into a funny issue where the ocean component was taking
significantly longer to write output at the end of the run than the other
components, and somehow the other components convinced the mediator that the
model had finished successfully even though the ocean component was still doing
stuff. This barrier makes everyone wait to catch up.
@mnlevy1981
Copy link
Contributor Author

@billsacks adding you as a reviewer because I'm basically asking Jim to review his own code and you're the first person I thought of who isn't Jim who is active in this repo. I won't be offended if you take yourself off the review list and / or add somebody else.

Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all, for getting this fixed! The fix looks fine to me, but I'm also going to run this by the ESMF team to see if they understand why this is needed. But I think it's fine to merge it if you want to get it in: it's hard to imagine this doing any harm. (Darn, I shouldn't have said that... feels like famous last words!)

@jedwards4b jedwards4b merged commit c750118 into ESCOMP:main Oct 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants