Skip to content

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Feb 27, 2025

Description of changes

Moves Izumi intel and gnu tests to Derecho.

Remaining work:

  • Update ChangeLog and ChangeSum

Notes to reviewer(s)

  • The new Python script, tools/contrib/remove_duplicate_tests.py, removes duplicate tests resulting from the Izumi-to-Derecho change. It also removes any extraneous whitespace from testlist_clm.xml.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No. However, a bunch of tests will be moved from Izumi to Derecho.

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

  • aux_clm passes except expected failures.

@samsrabin samsrabin added testing additions or changes to tests test: aux_clm Pass aux_clm suite before merging labels Feb 27, 2025
@samsrabin samsrabin self-assigned this Feb 27, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Feb 27, 2025
@samsrabin samsrabin moved this from Ready to start (or start again) to In progress - master/b4b-dev in CTSM: Upcoming tags Feb 27, 2025
@samsrabin samsrabin added this to the cesm3_0_beta06 milestone Feb 27, 2025
@samsrabin samsrabin marked this pull request as draft February 27, 2025 19:31
@samsrabin samsrabin marked this pull request as ready for review February 27, 2025 19:53
@samsrabin
Copy link
Member Author

samsrabin commented Feb 27, 2025

Those two Python scripts could actually be used in a GitHub workflow to check that testlist_clm.xml is well-formed... Will play with this but won't let it hold up this PR. @ekluzek

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the new testlist only has izumi_nag. And the changes all make sense to me. Some things I hadn't thought about you also brought in which makes sense. This will make the test list on Derecho, slightly longer, but that's fine.

I also think that the tools you made should become more mainstream. The tmp directory makes me think you were going to delete them. But, I don't think you should. We should do more of using tools like this. If they do become more mainstream, I'd like to see more testing for them, and probably a library level that removes some code duplication.

But, I think you bring this in like it is.

Migrate FATES parameter file switches to the namelist
@samsrabin samsrabin merged commit bfc5c31 into ESCOMP:master Mar 3, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master/b4b-dev to Done (non release/external) in CTSM: Upcoming tags Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR status: needs testing test: aux_clm Pass aux_clm suite before merging testing additions or changes to tests

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

Move non-nag Izumi tests to Derecho

2 participants