-
Notifications
You must be signed in to change notification settings - Fork 341
ctsm5.3.049: Preferentially use Podman for ctsm-docs container #3153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctsm5.3.049: Preferentially use Podman for ctsm-docs container #3153
Conversation
Automatically publish docs to this repo
37e29f6 to
a13fca6
Compare
Podman has permissions trouble for some reason.
No actual difference in contents expected.
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsrabin and I went over this, and the changes make sense. Some references to docker are changed to container or podman. The github runners need to use the docker Linux command line interface which is already valid under the license, since it's just using DockerEngine which is open-source under Apache 2.0. So the use of dockerfile is acceptable also for example.
I searched for docker in this version, and thought the uses of it made sense, since they are mostly in the .github workflow section.
I did notice that LILAC apparently uses docker, so there might be changes to the instructions for LILAC that we need to make. But, I'll open an issue for that.
This is a nice update that helps us to feel confident that we aren't inappropriately using something that we need to buy a license for.
Description of changes
Updates doc-builder to a version that prefers to use
podmaninstead ofdocker. Also updates documentation to instruct docs-writers to use Podman instead of Docker, along with some other improvements.podman machine startifCannot connect to Podmanin stderrSpecific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed: None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Yes; yes
Testing performed, if any: Documentation builds as expected.