Skip to content

Conversation

@lifang0209
Copy link

@lifang0209 lifang0209 commented May 30, 2025

Description of changes

  • Reduces fire count 99.6% above 2500 meters elevation based on GFED5 elevation bins of burned area, to eliminate overestimation of burning on Tibetan Plateau.
  • Updates deforestation fire parameterization based on ctsm5.4 LU and GFED5 burned area.
  • Fixes/improves comments

For now, also makes it so that crop fires don't happen if cropland is < 10% of the gridcell. However, this was only a kludge to avoid some mathematical weirdness with interpolation of agricultural peak burning month using average. This will be replaced by a more appropriate interpolation method with #3188, after which maybe remove 10% cropland threshold. However, that will make cropland burned area 10-30 Mha worse.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)? Yes. @lifang0209, can you please add a comment explaining the results before and after?

Any User Interface Changes (namelist or namelist defaults changes)?
Namelist defaults:

  • defo_fire_precip_thresh_bet for CRU-JRA
  • cli_scale for CRU-JRA and GSWP3
    Parameter file:
  • rswf_max(3)
  • rswf_min(3)
  • fsr_pft and fd_pft, although these changes cancel each other out

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:
@lifang0209, please add a comment explaining scientific testing.

Before merging:

  • rimport new parameter file.
  • aux_clm, expecting diffs only in li202[14]* fire methods. (2021 because of paramfile changes to rswf_min/max; 2024 due to those changes and others.)

@samsrabin samsrabin changed the title big commit Fire update May 2025 May 30, 2025
Copy link
Member

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple and mostly looks good. Just some changes to request, which I can handle.

  • defo_fire_precip_thresh_bet also needs to be changed, just for CRU-JRA. New value 3.0.
  • Change cropfire_a1 to 0.32, even if we get rid of the 10% crop fraction threshold
  • Change values on parameter file to match those in /glade/u/home/fangli/ctsm60_params.fire.crujra0530.nc:
    (1) rswf_max(3)=0.7d00
    (2) rswf_min(3)=0.35d00
    (3, 4) multiplying fsr_pft by 5 and dividing fd_pft by 5, based on FireAtlas and more reasonable, does not affect the results

@samsrabin samsrabin self-assigned this May 30, 2025
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science test: aux_clm Pass aux_clm suite before merging next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels May 30, 2025
@samsrabin samsrabin added the blocked: dependency Wait to work on this until dependency is resolved label May 30, 2025
@samsrabin
Copy link
Member

Blocked by #3188.

@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 26, 2025
@samsrabin
Copy link
Member

This is unblocked; now waiting on @lifang0209 to change the code to avoid the crop fraction threshold now that #3188 is merged.

@samsrabin samsrabin removed the blocked: dependency Wait to work on this until dependency is resolved label Jun 26, 2025
@lifang0209
Copy link
Author

@samsrabin Hi Sam,
(1) Using the new abm raw data, the following comment could be removed
"! cropf_col(c) * col%wtgcell(c) > 0.1_r8 is added because fires are rare in
! gridcells with limited cropland coverage based on GFED5. Also, this helps to
! avoid abm (crop fire peak month) regridding error from 0.05 degree to lower resolution
! The condition could be removed if CLM supports the use of mode in abm inputs regridding"

(2) remove “.and. cropf_col(c) * col%wtgcell(c) > 0.1_r8 ” from the condition statement
(3) cropfire_a1 = 0.34d00

@samsrabin
Copy link
Member

Great, thanks! Will do.

@samsrabin
Copy link
Member

Blocked while we wait for the 5.4 update, since this depends on new surface datasets.

@samsrabin samsrabin added the blocked: dependency Wait to work on this until dependency is resolved label Aug 6, 2025
@wwieder
Copy link
Contributor

wwieder commented Aug 6, 2025

We have the 5.4 branch. Can / should this PR get merged to the 5.4 branch so we can start evaluating fire results in coupled model tests?

@lifang0209
Copy link
Author

Yes, I think it should be merged.

@samsrabin samsrabin changed the base branch from master to alpha-ctsm5.4.CMIP7 August 12, 2025 16:28
@samsrabin samsrabin removed the blocked: dependency Wait to work on this until dependency is resolved label Aug 12, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Aug 12, 2025
@samsrabin
Copy link
Member

@wwieder @lifang0209 This is ready for testing! You can see the script I used to apply the paramfile changes here: /glade/work/samrabin/ctsm_ctsm6_li2024/tools/contrib/paramfile_changes/paramfile_chg_ctsm6_li2024.20250822.py.

No longer needed now that ESCOMP#3188 is resolved.
@samsrabin
Copy link
Member

Note that this will show a lot of diffs until the alpha-ctsm5.4.CMIP7 branch is brought up to date with ctsm5.3.071.

Set init_interp_fill_missing_urban_with_hd = .true. always

We will change this when we complete the ctsm5.4 release.
At that time we want the flag = .true. for IHist cases.
@samsrabin
Copy link
Member

samsrabin commented Aug 22, 2025

  • Perform final approving review once (a) at least ctsm5.3.071 has been merged into alpha-ctsm5.4.CMIP7 and (b) the corresponding tag on that branch has been merged into here.

@wwieder wwieder added this to the CESM3 Answer changing freeze milestone Aug 28, 2025
@wwieder
Copy link
Contributor

wwieder commented Aug 28, 2025

I suggest this come in after the 5.4 tag is made, giving us a bit more time to generate initial conditions and evaluate historical fire results on top of the PPE115 parameter file that's being used in NCAR/LMWG_dev#116

@lifang0209
Copy link
Author

@wwieder Hi Will, if the 5.4 tag uses CTSM5.4 surface and land use data, it‘s better to include the fire scheme updates. The updates include recalibration based on new abm (crop peak month) and land-use-based deforestation rate.

@ekluzek ekluzek moved this from In progress - master to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Sep 8, 2025
@samsrabin
Copy link
Member

@ekluzek Should this be tag alpha-ctsm5.4.CMIP7.10.ctsm5.3.068?

@samsrabin samsrabin self-requested a review September 8, 2025 16:47
@github-project-automation github-project-automation bot moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to In progress - master in CTSM: Upcoming tags Sep 8, 2025
Update the ctsm5.4 alpha branch to ctsm5.3.071

PR ESCOMP#3464
@samsrabin samsrabin merged commit 32a4310 into ESCOMP:alpha-ctsm5.4.CMIP7 Sep 9, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Sep 9, 2025
samsrabin added a commit to samsrabin/CTSM that referenced this pull request Sep 9, 2025
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science test: aux_clm Pass aux_clm suite before merging

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

3 participants