Skip to content

ctsm5.3.054: CDEPS: Allow anomaly forcings with any DATM #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025
Merged

ctsm5.3.054: CDEPS: Allow anomaly forcings with any DATM #3212

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3bc488
CDEPS: Allow anomaly forcings w/ any DATM.
samsrabin Jun 1, 2025
128539c
Three ctsm_sci tests now expected to pass.
samsrabin Jun 1, 2025
619bc5c
Update ChangeLog/ChangeSum
samsrabin Jun 2, 2025
3ccf1b8
Point CDEPS at cdeps1.0.75.
samsrabin Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ fxDONOTUSEurl = https://github.com/ESCOMP/CMEPS.git

[submodule "cdeps"]
path = components/cdeps
url = https://github.com/ESCOMP/CDEPS.git
fxtag = cdeps1.0.73
url = https://github.com/samsrabin/CDEPS.git
fxtag = 0a59658973f1d9d1155f884df3a578fd59a2fd60
fxrequired = ToplevelRequired
# Standard Fork to compare to with "git fleximod test" to ensure personal forks aren't committed
fxDONOTUSEurl = https://github.com/ESCOMP/CDEPS.git
Expand Down
21 changes: 0 additions & 21 deletions cime_config/testdefs/ExpectedTestFails.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,27 +36,6 @@
</phase>
</test>

<test name="SMS_Ld5.f09_t232.ISSP245Clm60BgcCropCrujra.derecho_intel.clm-ciso_dec2050Start">
<phase name="SETUP">
<status>FAIL</status>
<issue>#3209</issue>
</phase>
</test>

<test name="SMS_Ld5.f09_t232.ISSP370Clm60BgcCropCrujra.derecho_intel.clm-ciso_dec2050Start">
<phase name="SETUP">
<status>FAIL</status>
<issue>#3209</issue>
</phase>
</test>

<test name="SMS_Ld5.f09_t232.ISSP585Clm60BgcCropCrujra.derecho_intel.clm-ciso_dec2050Start">
<phase name="SETUP">
<status>FAIL</status>
<issue>#3209</issue>
</phase>
</test>

<test name="SMS_Ld5.f09_g17.IHistClm50Sp.derecho_intel.clm-nofire">
<phase name="SHAREDLIB_BUILD">
<status>FAIL</status>
Expand Down
2 changes: 1 addition & 1 deletion components/cdeps
Open in desktop
Submodule cdeps updated 3 files
+2 −0 datm/atm_comp_nuopc.F90
+0 −13 datm/cime_config/buildnml
+10 −0 datm/cime_config/testdefs/testlist_datm.xml
74 changes: 74 additions & 0 deletions doc/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,78 @@
===============================================================
Tag name: ctsm5.3.054
Originator(s): samrabin (Sam Rabin, UCAR/TSS)
Date: Mon Jun 2 11:39:50 MDT 2025
One-line Summary: CDEPS: Allow anomaly forcings with any DATM

Purpose and description of changes
----------------------------------

Updates CDEPS to version cdeps1.0.75, allowing anomaly forcings with any datm_mode. CRU-JRA thus now works with anomalies.

Also brings in cdeps1.0.74: "In DATM with cplhist mode, make 1st timestep same as cam7 when using the cam7 option."



Significant changes to scientifically-supported configurations
--------------------------------------------------------------

Does this tag change answers significantly for any of the following physics configurations?
(Details of any changes will be given in the "Answer changes" section below.)

[Put an [X] in the box for any configuration with significant answer changes.]

[ ] clm6_0

[ ] clm5_0

[ ] ctsm5_0-nwp

[ ] clm4_5


Bugs fixed
----------

List of CTSM issues fixed (include CTSM Issue # and description):
- [Issue #3209: [CDEPS] Allow anomaly forcings with any datm](https://github.com/ESCOMP/CTSM/issues/3209)


Testing summary:
----------------

regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):

derecho ----- OK
izumi ------- OK

ctsm_sci (just three tests that were failing before)
derecho ---- PASS


Answer changes
--------------

Changes answers relative to baseline: Yes (although not in tests)

Summarize any changes to answers, i.e.,
- what code configurations: CPLHIST
- what platforms/compilers: All
- nature of change (roundoff; larger than roundoff/same climate; new climate): Roundoff

Only affects first timestep under lnd_tuning_mode clm6_0_cam7.0.


Other details
-------------

List any git submodules updated (cime, rtm, mosart, cism, fates, etc.):
- cdeps updated from cdeps1.0.73 to cdeps1.0.75

Pull Requests that document the changes (include PR ids):
- [Pull Request #3212: ctsm5.3.054: CDEPS: Allow anomaly forcings with any DATM by samsrabin](https://github.com/ESCOMP/CTSM/pull/3212)

===============================================================
===============================================================
Tag name: ctsm5.3.053
Originator(s): samrabin (Sam Rabin, UCAR/TSS)
Date: Fri May 30 14:56:48 MDT 2025
Expand Down
1 change: 1 addition & 0 deletions doc/ChangeSum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Tag Who Date Summary
============================================================================================================================
ctsm5.3.054 samrabin 06/02/2025 CDEPS: Allow anomaly forcings with any DATM
ctsm5.3.053 samrabin 05/30/2025 Fix and improve anomaly forcings for ISSP cases
ctsm5.3.052 erik 05/30/2025 Changes to MEGAN needed for coupled cases
ctsm5.3.051 erik 05/28/2025 Update submodules to cesm3_0_beta06 versions and update MEGAN/drydep test namelist
Expand Down
Loading