Skip to content

Include abm = 13 values when determining dominant abm in mksurfdata_esmf #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 18, 2025
Merged

Include abm = 13 values when determining dominant abm in mksurfdata_esmf #3224

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
88a32eb
Include abm = 13 values when determining dominant abm in mksurfdata_esmf
slevis-lmwg Jun 4, 2025
7477372
Change unsetmon from 13 to 14
slevis-lmwg Jun 4, 2025
16a1921
Adding comments explaining some of mkagfirepkmonthMod.F90
slevis-lmwg Jun 4, 2025
7d7a49e
mkagfirepkmonthMod: Add some TODOs.
samsrabin Jun 5, 2025
7f28c6f
Remove unsetmon as recommended in the code review
slevis-lmwg Jun 5, 2025
1469512
Document more variables as recommended in the code review
slevis-lmwg Jun 5, 2025
f70e958
Merge tag 'ctsm5.3.055' into abm_dominant_in_mksurfdata_esmf
slevis-lmwg Jun 5, 2025
b9feb79
Merge remote-tracking branch 'escomp/alpha-ctsm5.4.CMIP7' into abm_do…
slevis-lmwg Jun 13, 2025
ff3bc9e
Correct a message to the user in gen_mksurfdata_jobscript_*.py files
slevis-lmwg Jun 13, 2025
bd3ce96
Corrections to messages to the user
slevis-lmwg Jun 13, 2025
5d426ba
Refine message to the user
slevis-lmwg Jun 13, 2025
bd0c628
Bring back unsetmon but equal to 14 for ocean to not skew the regridding
slevis-lmwg Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tools/mksurfdata_esmf/src/mkagfirepkmonthMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ module mkagfirepkmonthMod

public :: mkagfirepkmon ! Set agricultural fire peak month

integer , parameter :: min_valid = 1
integer , parameter :: max_valid = 12
integer , parameter :: unsetmon = 13
integer , parameter :: min_valid = 1 ! month value for January
integer , parameter :: max_valid = 13 ! value for no agricultural fire
integer , parameter :: unsetmon = 14 ! maximum value expected in the output file if raw dataset includes values outside the 1 through 13 range

type(ESMF_DynamicMask) :: dynamicMask

Expand All @@ -36,6 +36,10 @@ module mkagfirepkmonthMod
subroutine mkagfirepkmon(file_mesh_i, file_data_i, mesh_o, pioid_o, rc)
!
! Make agricultural fire peak month data from higher resolution data
! by selecting the dominant value from values 1 through 13
! where 13 means no agricultural fire.
!
! The relevant subroutine is get_dominant_indices.
!
! input/output variables
character(len=*) , intent(in) :: file_mesh_i ! input mesh file name
Expand Down Expand Up @@ -142,6 +146,7 @@ subroutine mkagfirepkmon(file_mesh_i, file_data_i, mesh_o, pioid_o, rc)
! Create a dynamic mask object
! The dynamic mask object further holds a pointer to the routine that will be called in order to
! handle dynamically masked elements - in this case its DynMaskProc (see below)
! This calls subroutine get_dominant_indices
call ESMF_DynamicMaskSetR4R8R4(dynamicMask, dynamicMaskRoutine=get_dominant_indices, &
handleAllElements=.true., rc=rc)
if (chkerr(rc,__LINE__,u_FILE_u)) return
Expand Down