Skip to content

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Jul 10, 2025

Description of changes

⚠️ Actually non-b4b for one test (see #3315).

PRs included:

Specific notes

Contributors other than yourself, if any: @sy-li, @ekluzek, @billsacks, @olyson

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? Only for one test (not actual runs); see #3315.

The test that changes is SMS_D_Ln1.f10_f10_mg37.I2000Clm50BgcCropQianRs.derecho_intel.clm-run_self_tests. Here are the changed fields:

 RMS lndImp_Fall_evap                 4.0408E-06            NORMALIZED  1.8816E-01
 RMS lndImp_Fall_lat                  1.1481E+01            NORMALIZED  1.8864E-01
 RMS lndImp_Fall_lwup                 8.1192E+00            NORMALIZED  3.0125E-02
 RMS lndImp_Fall_sen                  3.0676E+01            NORMALIZED  4.1299E-01
 RMS lndImp_Fall_swnet                1.2477E+00            NORMALIZED  1.0133E-02
 RMS lndImp_Fall_taux                 5.5936E-03            NORMALIZED  1.3070E-01
 RMS lndImp_Fall_tauy                 5.5936E-03            NORMALIZED  1.3070E-01
 RMS lndImp_Sl_anidf                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_anidr                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_avsdf                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_avsdr                  2.0554E-03            NORMALIZED  1.0261E-02
 RMS lndImp_Sl_fv                     6.0521E-03            NORMALIZED  3.1427E-02
 RMS lndImp_Sl_qref                   3.7818E-05            NORMALIZED  9.6302E-03
 RMS lndImp_Sl_ram1                   1.0268E+01            NORMALIZED  5.0912E-02
 RMS lndImp_Sl_snowh                  2.4103E-03            NORMALIZED  8.7984E-02
 RMS lndImp_Sl_t                      1.8861E+00            NORMALIZED  7.2076E-03
 RMS lndImp_Sl_tref                   2.1301E-01            NORMALIZED  8.0407E-04
 RMS lndImp_Sl_u10                    2.7456E-02            NORMALIZED  1.3279E-02

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: aux_clm in progress.

olyson and others added 30 commits May 14, 2025 13:07
This is the last step needed to make it so that UNIT tests are portable to machines other than those defined in CESM, and thus:
Resolves ESCOMP#2984.
Since they were working on the same triggers.
Disallow implicit conversion because we want the user to specify which type they want.
samsrabin and others added 23 commits June 27, 2025 16:33
subset_data: Fix conversion of Longitude to string
add notes to specify snow/ice units are liquid water equivalent
The previous logic caused problems if "GRAIN" appeared in two (or more)
strings, where one was a substring of the other. For example, in
LREPRSTRUCT_Ly1_P128x1.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-ciso--clm-cropMonthOutput,
before this replacement, one line contained 'GRAINN_TO_FOOD' and a later
line contained (among other things) "'GRAINN_TO_FOOD_PERHARV',
'GRAINN_TO_FOOD_ANN'". This was problematic because the first
replacement of GRAINN_TO_FOOD incorrectly led to replacements in the
later strings as well.

This new logic should solve this issue.

Resolves ESCOMP#3313
Add decomp_init testlist and some extra PE layouts for some grids
…eplacement

Fix string replacements in lreprstruct test
Fix ESCOMP#3110 (Initialization of historical using CTSM5.4 surface datasets fails)
tips-for-working-with-rst.md: Add common errors, cheatsheet links.
Put instantaneous and non-inst. fields on separate hist files

hX and rhX files become hXa/hXi and rhXa/rhXi

This tag comes with updates to mosart and rtm:
 mosart1.1.08 --> mosart1.1.09
 rtm1_0_86 --> rtm1_0_87
@samsrabin samsrabin self-assigned this Jul 10, 2025
@samsrabin samsrabin added the non-bfb Changes answers (incl. adding tests) label Jul 10, 2025
@samsrabin samsrabin merged commit d43d777 into ESCOMP:master Jul 10, 2025
8 checks passed
@samsrabin samsrabin changed the title b4b-dev merge 2025-07-10 ctsm5.3.063: b4b-dev merge 2025-07-10 Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-bfb Changes answers (incl. adding tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants