-
Notifications
You must be signed in to change notification settings - Fork 341
ctsm5.3.063: b4b-dev merge 2025-07-10 #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last step needed to make it so that UNIT tests are portable to machines other than those defined in CESM, and thus: Resolves ESCOMP#2984.
Since they were working on the same triggers.
Disallow implicit conversion because we want the user to specify which type they want.
subset_data: Fix conversion of Longitude to string
add notes to specify snow/ice units are liquid water equivalent
… with faster time-step
The previous logic caused problems if "GRAIN" appeared in two (or more) strings, where one was a substring of the other. For example, in LREPRSTRUCT_Ly1_P128x1.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-ciso--clm-cropMonthOutput, before this replacement, one line contained 'GRAINN_TO_FOOD' and a later line contained (among other things) "'GRAINN_TO_FOOD_PERHARV', 'GRAINN_TO_FOOD_ANN'". This was problematic because the first replacement of GRAINN_TO_FOOD incorrectly led to replacements in the later strings as well. This new logic should solve this issue. Resolves ESCOMP#3313
Add decomp_init testlist and some extra PE layouts for some grids
…eplacement Fix string replacements in lreprstruct test
Fix ESCOMP#3110 (Initialization of historical using CTSM5.4 surface datasets fails)
tips-for-working-with-rst.md: Add common errors, cheatsheet links.
Put instantaneous and non-inst. fields on separate hist files hX and rhX files become hXa/hXi and rhXa/rhXi This tag comes with updates to mosart and rtm: mosart1.1.08 --> mosart1.1.09 rtm1_0_86 --> rtm1_0_87
ekluzek
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
PRs included:
Specific notes
Contributors other than yourself, if any: @sy-li, @ekluzek, @billsacks, @olyson
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? Only for one test (not actual runs); see #3315.
The test that changes is
SMS_D_Ln1.f10_f10_mg37.I2000Clm50BgcCropQianRs.derecho_intel.clm-run_self_tests. Here are the changed fields:Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: aux_clm in progress.