Skip to content

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Sep 8, 2025

Description of changes

Adds dask 2025.7.0 to ctsm_pylib.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

  • Python unit tests on Derecho
  • Python system tests on Derecho
  • clm_pymods suite comparing to ctsm5.3.071

@samsrabin samsrabin self-assigned this Sep 8, 2025
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability bfb bit-for-bit test: python Pass clm_pymods test suite plus Python sys/unit tests before merging performance idea or PR to improve performance (e.g. throughput, memory) labels Sep 8, 2025
@samsrabin samsrabin marked this pull request as ready for review September 8, 2025 16:23
@samsrabin samsrabin requested a review from ekluzek September 8, 2025 16:26
@samsrabin samsrabin moved this from Ready to start (or start again) to In progress - b4b-dev in CTSM: Upcoming tags Sep 8, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Sep 8, 2025
@samsrabin samsrabin added the PR status: awaiting review Work on this PR is paused while waiting for review. label Sep 8, 2025
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously dead simple, so can come in.

The one suggestion I have though that we should make sure we do is to update the

README.python_pkgs.rst

file, and remove the line about dask. There's a couple other lines that should be changed as well to align with how we are doing things now. We could do that here, or in another small PR to b4b-dev.

I also find mention of dask, scattered throughout the repo, and we likely should handle some of those. A lot of those are crop calendar things that you can handle @samrabin. I added handling the others as part of #3380.

@github-project-automation github-project-automation bot moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Sep 8, 2025
@samsrabin
Copy link
Member Author

Good catch, @ekluzek. I've deleted references to dask where they don't belong. There are other references but those should stay.

@samsrabin samsrabin merged commit 6c09db5 into ESCOMP:b4b-dev Sep 8, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit enhancement new capability or improved behavior of existing capability performance idea or PR to improve performance (e.g. throughput, memory) PR status: awaiting review Work on this PR is paused while waiting for review. test: python Pass clm_pymods test suite plus Python sys/unit tests before merging

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

2 participants