Skip to content

Conversation

@ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Sep 18, 2025

Description of changes

Add two new PE layouts for mpas3p75 a "L" and "Lhm" option.
Add tests of these to the uhr_decomp_init test list

Specific notes

Contributors other than yourself, if any: @briandobbins

CTSM Issues Fixed (include github issue #):
Fixes #3489

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes

Allows using the "L" or "Lhm" option for the PE layout for the mpasa3p75 grid

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: So far just running the uhr_decomp_init test list

@ekluzek ekluzek self-assigned this Sep 18, 2025
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability testing additions or changes to tests bfb bit-for-bit labels Sep 18, 2025
@ekluzek ekluzek added performance idea or PR to improve performance (e.g. throughput, memory) size: small labels Sep 18, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Sep 18, 2025
@ekluzek ekluzek marked this pull request as ready for review September 18, 2025 05:32
@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - b4b-dev in CTSM: Upcoming tags Sep 18, 2025
@ekluzek ekluzek moved this from Todo to In Progress in LMWG: Sprint Planning Board Sep 18, 2025
@ekluzek ekluzek changed the base branch from master to b4b-dev September 18, 2025 05:34
@ekluzek ekluzek requested a review from slevis-lmwg September 18, 2025 05:34
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 18, 2025

Here's the init results for these two, which clearly show the excessive amount of time being spend in decompInit. This is based off of b4b-dev so doesn't have the extra timers, but shows the principle. It also shows how having more memory on each node saves a significant amount of time.

For mpasa3p75 L:

  [ESMF]                                                                     38400  38400  1        2261.4802   2261.4680   30547   2261.4900   30516
    [ensemble] Init 1                                                        38400  38400  1        2242.6065   2242.4292   35762   2242.7544   11944
      [ESM0001] IPDv02p3                                                     38400  38400  1        2183.6020   2183.5979   27186   2183.6047   26932
        [LND] IPDv01p3                                                       38400  38400  1        2001.9617   2001.9426   18534   2001.9717   37135
          lc_lnd_set_decomp_and_domain_from_readmesh                         38400  38400  1        1971.5981   1971.5962   7759    1971.6025   4342

For mpasa3p75 Lhm:

  [ESMF]                                                                     38400  38400  1        1102.8676   1102.8573   35995   1102.8741   34724
    [ensemble] Init 1                                                        38400  38400  1        1085.9691   1085.8829   22560   1086.0488   25615
      [ESM0001] IPDv02p3                                                     38400  38400  1        1039.9769   1039.9738   31175   1039.9792   36776
        [LND] IPDv01p3                                                       38400  38400  1        900.3199    900.3007    3036    900.3278    20220
          lc_lnd_set_decomp_and_domain_from_readmesh                         38400  38400  1        873.0665    873.0646    5301    873.0708    9880

I'll get this on a branch with the extra timers so we can see the details of how this performs against the new case with mpi_scan. Based on our other results the rest of lc_lnd_set_decomp_and_domain_from_readmesh should be around 20 seconds. So even if you quadruple that you have an enormous amount of time spent in decompInit_lnd.

…, so a standard non strange test-setup is run in the testlist
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek I like the comments, but I don't like the use of Clm45 compsets in the new tests. I'm approving, and you can decide what's best.

@github-project-automation github-project-automation bot moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Sep 18, 2025
@ekluzek ekluzek merged commit fba3fd8 into ESCOMP:b4b-dev Sep 22, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Sep 22, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in LMWG: Sprint Planning Board Sep 22, 2025
@ekluzek ekluzek deleted the L_pelayout_mpasa3p75 branch September 22, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit enhancement new capability or improved behavior of existing capability performance idea or PR to improve performance (e.g. throughput, memory) size: small testing additions or changes to tests

Projects

Status: Done (non release/external)
Status: Done

Development

Successfully merging this pull request may close these issues.

Add two more PE layouts for mpasa3p75

2 participants