Skip to content

Conversation

@slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Oct 17, 2025

Description of changes

Updated raw datasets for ctsm5.4.

Specific notes

Contributors other than yourself, if any:
@lawrencepj1 @ekluzek

CTSM Issues Fixed (include github issue #):
Resolves #3529

Are answers expected to change (and if so in what way)?
Yes, new raw data => new fsurdat/landuse files.

Any User Interface Changes (namelist or namelist defaults changes)?
New raw data.

Testing performed, if any:
So far, ran make all with the new raw lai and soilcolor.
Now running make all also with the new landuse files.

This is identical to and replaces the earlier commit c3e1ca1 that I had to reverse.
...generated when the corrected lai & soilcolor raw datasets were
generated; we're switching to these new landuse files because they ended
up with 0.01% diffs in PCT_NAT_PFT and PCT_CFT values relative to the
previous version
@slevis-lmwg slevis-lmwg self-assigned this Oct 17, 2025
@slevis-lmwg

This comment was marked as resolved.

I started branch new_raw_lai_and_soilcolor from make_ctsm54_datasets,
so I'm keeping new_raw_... up to date with its parent branch before I
start a new branch from new_raw_...
@slevis-lmwg slevis-lmwg moved this from Todo to In Progress in LMWG: Sprint Planning Board Oct 17, 2025
@slevis-lmwg slevis-lmwg changed the title New raw lai, soilcolor, 1700-2023 landuse files, and NOANTHRO landuse file alpha-ctsm5.4.CMIP7.14.ctsm5.3.079: New raw lai, soilcolor, 1700-2023 landuse files, and NOANTHRO landuse file Oct 17, 2025
@slevis-lmwg
Copy link
Contributor Author

Got confirmation from Adam H. that we're doing 1979-2023 for VR and ne120 grids, so I'm making minor adjustments to the Makefile and running make crop-global-hist-vrandne120 to confirm that nothing broke.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 17, 2025

derecho testing (next commit included):

PASS make lint and black
OK ./build-namelist_test.pl
PASS ./run_ctsm_py_tests -u and -s

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 17, 2025

@ekluzek other than waiting for this test that's in the queue, I'm under the impression that this is the PR that we will make the dataset tag with. Does that sound correct to you? We can discuss on Monday.

UPDATE
Above test worked.

@slevis-lmwg slevis-lmwg requested a review from ekluzek October 20, 2025 18:51
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to trust @slevis-lmwg has done the needed testing and has made sure the filenames are correct. Most of this is just bringing in the new files.

There's some removal of notes about NOANTHRO. And it looks like that catches everything.

There's also changes to remove pointing to SSP3-4.5 and using hist that end in 2023. The suggestion there is to keep the former, but comment it out and add a line that says add this back in when CMIP7 future scenarios are available. You can decide on that on your own. We possibly should just remove the future scenario options and only add it when we CMIP7 versions. See the comment about this. That could be something we make into an issue and do later.

So approving and you can decide about comments to add to layout the bit about using a midpoint future scenario for when CMIP7 future scenarios are made available.

@slevis-lmwg
Copy link
Contributor Author

I'm about to merge this PR and make new branch tag alpha-ctsm5.4.CMIP7.14.ctsm5.3.079 with which I will run the "official" make all.

@slevis-lmwg slevis-lmwg merged commit 7e9c184 into ESCOMP:alpha-ctsm5.4.CMIP7 Oct 22, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in LMWG: Sprint Planning Board Oct 22, 2025
@slevis-lmwg slevis-lmwg deleted the new_raw_lai_and_soilcolor branch October 22, 2025 00:04
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Oct 22, 2025
@slevis-lmwg slevis-lmwg moved this from Ready to start (or start again) to release/externals tags done in CTSM: Upcoming tags Oct 22, 2025
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 22, 2025

After the fact, running ctsm_sci on derecho to confirm no issues with NoAnthro compsets from the change in cime_config/config_component.xml
./run_sys_tests -s ctsm_sci -c ctsm_sci-alpha-ctsm5.4.CMIP7.12.ctsm5.3.075 -g ctsm_sci-alpha-ctsm5.4.CMIP7.15.ctsm5.3.079

When all goes well, I will turn off all-subset in the Makefile and will submit make all.

UPDATE 1
Unexpected failures in the VR grids because not finding default flanduse_timeseries. They still point to the ctsm5.3 ones, so investigating.

UPDATE 2

  • I had not specified cmip_era = 'cmip7' in namelist_defaults for the VR grids invoked by historical cases. But still seeing failures, so resolve tomorrow. How did ctsm_sci work for the cmip_era PR?
  • When fixed, confirm with Erik, but I may not need this change to submit make all. I will just need to make the correction in the subsequent alpha5.4 tag as I proceed with the "update namelist_defaults" checkbox in ctsm5.4.000: Update to CMIP7 LULCC forcings #2851.

UPDATE 3

  • Went back to alpha-ctsm5.4.CMIP7.12.ctsm5.3.075 and got the error with this test:
    ./create_test SMS_Ln9.ne0POLARCAPne30x4_ne0POLARCAPne30x4_mt12.IHistClm60Sp.derecho_intel.clm-clm60cam7LndTuningMode_1979Start--clm-nofireemis
  • Went back to the commit where ctsm_sci worked and made my way back. Isolated to this commit: 3b15fbc
  • Found the problem: VR grids get assigned an SSP in this line
    cime_config/config_component.xml: <value compset="^HIST" grid="ne0np4" >1850-2100_SSP2-4.5_transient</value>
    yet cmip_era = 'cmip7' for IHist cases, and these are incompatible. HOWEVER, in ctsm5.4 we are changing VR grids to 1979-2023, so we can remove/replace the line assigning an SSP. Added checkbox to ctsm5.4.000: Update to CMIP7 LULCC forcings #2851.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: release/externals tags done
Status: Done

Development

Successfully merging this pull request may close these issues.

Preliminary ctsm5.4 datasets when run in SP mode have crop run as bare ground

2 participants