Skip to content

Conversation

@wwieder
Copy link
Contributor

@wwieder wwieder commented Nov 24, 2025

Description of changes

Fire, glacier, and parameter updates to merge after the 5.4 release is ready

Specific notes

WIP,

  • Default parameter file needs to be rimported,
  • fire modifications should be checked, &
  • CISM updates are done correctly?

Contributors other than yourself, if any:
@lifang0209 , @gunterl, @linniahawkins

CTSM Issues Fixed (include github issue #):
Closes #3598
Closes #3608
Closes #3594 by merging the changes from #3597 to this PR

Are answers expected to change (and if so in what way)?
Yes, this is an answer changing tag

Any User Interface Changes (namelist or namelist defaults changes)?
NA
Does this create a need to change or add documentation? Did you do so?

@wwieder wwieder self-assigned this Nov 24, 2025
@wwieder wwieder added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science labels Nov 24, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Nov 24, 2025
@wwieder wwieder added this to the cesm3_0_beta08 milestone Nov 24, 2025
@slevis-lmwg
Copy link
Contributor

@ekluzek to make it easier for us to review, would it make sense for me to try rebasing this PR to the post45 branch?

@wwieder
Copy link
Contributor Author

wwieder commented Nov 24, 2025

It does make it hard to see the diffs here, sorry maybe I should have used a different starting point? Let me know if I can make things easier on my end?

@slevis-lmwg slevis-lmwg changed the base branch from master to post-5.4 November 25, 2025 01:33
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwieder thanks for these changes.

  • I gave some instructions regarding the cism update that you can try or ignore, since @ekluzek or I will merge the PR, and we can complete that step.
  • For the same reason, I will not "approve" for now. When Erik or I prepare to merge, we can approve.

@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Nov 25, 2025
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Nov 25, 2025

From meeting with @wwieder and @ekluzek:
@slevis-lmwg start testing.

On izumi I was waiting for updated baseline permissions (now ready, but wait).
On derecho I got:

FAIL ./run_sys_tests -s aux_clm -c post-5.4.n00 -g post-5.4.n01_pr3626
OK build-namelist_test.pl

Looking at unexpected failures with ./cs.status.fails | grep -v NLCOMP | grep -v 'BASELINE post-5.4.n00: DIFF' | grep -v PASS:

FAIL ERP_D_Ld5.f10_f10_mg37.I1850Clm50BgcCropG.derecho_gnu.clm-glcMEC_changeFlags RUN
FAIL ERI_D.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningModeLDust RUN
FAIL ERP_D_Ld9.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam6LndTuningMode RUN
FAIL ERP_D_Ld9.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningModeLDust RUN
FAIL ERP_D_Ld9.ne30pg3_t232.IHistClm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningModeLDust RUN
FAIL ERP_P256x2_D_Ld5.f19_g17_gris4.I1850Clm50BgcCropG.derecho_intel.clm-glcMEC_increase RUN
FAIL ERP_P64x2_D_Ld10.f10_f10_mg37.IHistClm50SpG.derecho_intel.clm-glcMEC_decrease--clm-nofireemis RUN
FAIL ERS_D_Ld12.f10_f10_mg37.I1850Clm50BgcCropG.derecho_intel.clm-glcMEC_spunup_inc_dec_bgc RUN
FAIL ERS_D_Ld9.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningMode RUN
FAIL ERS_Ly3_P64x2.f10_f10_mg37.IHistClm50BgcCropG.derecho_intel.clm-cropMonthOutput RUN
FAIL SMS_Lm1.ne30pg3_t232.I1850Clm60BgcCropCrujraG.derecho_intel.clm-clm60cam7LndTuningMode RUN
FAIL SMS_Lm1.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningMode RUN
FAIL SMS_Ly3.f10_f10_mg37.I1850Clm50SpG.derecho_intel.clm-glcMEC_long--clm-nofireemis RUN

Investigate...

@slevis-lmwg slevis-lmwg self-assigned this Nov 25, 2025
@slevis-lmwg slevis-lmwg moved this from Todo to In Progress in LMWG: Sprint Planning Board Nov 25, 2025
@slevis-lmwg
Copy link
Contributor

According to @ekluzek, update ccs_config, too. Erik may post more about that.

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 1, 2025

The fails are likely due to needing ccs_config6.0.62 or beyond as mentioned here:

#3600 (comment)

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are straight forward, so not much to say.

I do have some comments about ccs_config. I was happy that you figured out a comment to remove. I ask about the removal of fsat on peatland fires since that was in all the previous versions. I'm guessing there's an update to the tech note that might need to happen along with that one. I think I figured out where that is, so should be easy to change.

@github-project-automation github-project-automation bot moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to In progress - master in CTSM: Upcoming tags Dec 1, 2025
@slevis-lmwg slevis-lmwg mentioned this pull request Dec 2, 2025
@slevis-lmwg slevis-lmwg merged commit 491514e into ESCOMP:post-5.4 Dec 2, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Dec 2, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in LMWG: Sprint Planning Board Dec 2, 2025
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Dec 2, 2025

Tagged as post-5.4.n01 and made corresponding baselines on izumi and derecho.
Now realizing that I didn't update the NEON related baselines for the change to v4.
I should rerun aux_clm_mpi_serial to update those baselines:

OK ./run_sys_tests -s aux_clm_mpi_serial -c post-5.4.n00 -g post-5.4.n01
Checked with
./cs.status.fails | grep -v PASS | grep -v 'n00: DI' | grep -v 'ise bit-fo' | grep -v NLCOMP

@slevis-lmwg slevis-lmwg deleted the post-5.4_namelist_updates branch December 2, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science

Projects

Status: Done (non release/external)
Status: Done

Development

Successfully merging this pull request may close these issues.

Fire calibration for CLM6 release Change default snow_thermal_cond_glc_method

3 participants