-
Notifications
You must be signed in to change notification settings - Fork 341
Post 5.4 namelist updates #3626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post 5.4 namelist updates #3626
Conversation
|
@ekluzek to make it easier for us to review, would it make sense for me to try rebasing this PR to the post45 branch? |
|
It does make it hard to see the diffs here, sorry maybe I should have used a different starting point? Let me know if I can make things easier on my end? |
slevis-lmwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
From meeting with @wwieder and @ekluzek: On izumi I was waiting for updated baseline permissions (now ready, but wait). Looking at unexpected failures with Investigate... |
|
According to @ekluzek, update ccs_config, too. Erik may post more about that. |
|
The fails are likely due to needing ccs_config6.0.62 or beyond as mentioned here: |
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are straight forward, so not much to say.
I do have some comments about ccs_config. I was happy that you figured out a comment to remove. I ask about the removal of fsat on peatland fires since that was in all the previous versions. I'm guessing there's an update to the tech note that might need to happen along with that one. I think I figured out where that is, so should be easy to change.
|
Tagged as post-5.4.n01 and made corresponding baselines on izumi and derecho.
|
Description of changes
Fire, glacier, and parameter updates to merge after the 5.4 release is ready
Specific notes
WIP,
Contributors other than yourself, if any:
@lifang0209 , @gunterl, @linniahawkins
CTSM Issues Fixed (include github issue #):
Closes #3598
Closes #3608
Closes #3594 by merging the changes from #3597 to this PR
Are answers expected to change (and if so in what way)?
Yes, this is an answer changing tag
Any User Interface Changes (namelist or namelist defaults changes)?
NA
Does this create a need to change or add documentation? Did you do so?