Skip to content

Conversation

@olyson
Copy link
Contributor

@olyson olyson commented Dec 2, 2025

Description of changes

           ! Add esai to sa_leaf if elai is less than threshold.
           ! Intended to avoid small sa_leaf which leads to small leaf conductance
           ! and high leaf temperature. This in turn can lead to unrealistically
           ! high surface temperatures passed to the atmospheric model (The RRTMGP
           ! component in particular, which returns an error and stops the model
           ! if the surface temperature is greater than 355K).
           ! See https://github.com/ESCOMP/CTSM/issues/3589 for more info.
           ! The 0.1_r8 value is fairly arbitrary but has been effective in
           ! avoiding RRTMGP errors in CESM3 development simulations.

Specific notes

Contributors other than yourself, if any: @swensosc , @slevis-lmwg

CTSM Issues Fixed (include github issue #): #3589

Are answers expected to change (and if so in what way)? Yes (similar climate though)

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? Yes. No.

Testing performed, if any:
See #3589 for testing description. I have not run any CTSM system testing.

Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I will start aux_clm to confirm nothing's broken. Also I will try rebasing to the post-5.4 branch to get this in more efficiently.

@slevis-lmwg slevis-lmwg added the non-bfb Changes answers (incl. adding tests) label Dec 3, 2025
@slevis-lmwg slevis-lmwg changed the base branch from master to post-5.4 December 3, 2025 16:50
@slevis-lmwg slevis-lmwg changed the base branch from post-5.4 to master December 3, 2025 16:52
@slevis-lmwg
Copy link
Contributor

Rebasing didn't work, as it ended up with 44 files changed, so I reverted to master. I thought rebasing would apply the same changes but starting from post-5.4 instead of starting from master. Clearly there's something about rebasing that I don't get, because sometimes it does what I expect and sometimes not.

Maybe if I update the post_5.4 branch to ctsm5.3.085? I will think about it. I will hold off on aux_clm for now.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olyson thanks so much for figuring this out.

I had some simple suggestions. But, then when I looked closer I saw some other things that I think need to be done. And I then saw a way to make the code both clearer to humans and more maintainable so that the contents of the if blocks didn't need to be matched if something changed. So I think it's all worth doing.

@swensosc
Copy link
Contributor

swensosc commented Dec 3, 2025 via email

! component in particular, which returns an error and stops the model
! if the surface temperature is greater than 355K).
! See https://github.com/ESCOMP/CTSM/issues/3589 for more info.
! The 0.1_r8 value is arbitrary but has been effective in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this part of the comment is above, you could remove these two lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks. Done.

@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Sprint Planning Board Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-bfb Changes answers (incl. adding tests)

Projects

Status: Stalled

Development

Successfully merging this pull request may close these issues.

5 participants