Phase 2 of rk_stratiform CCPPization: diagnostic schemes

[jimmielin]

Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

• Closes Convert rk_stratiform_tend (CAM4) to CCPP #190 completes conversion of rk_stratiform microphysics to CCPP

List all namelist files that were added or changed: N/A

List all files eliminated and why: N/A

List all files added and what they do:

A       schemes/sima_diagnostics/compute_cloud_fraction_diagnostics.F90
A       schemes/sima_diagnostics/compute_cloud_fraction_diagnostics.meta
A       schemes/sima_diagnostics/convective_cloud_cover_diagnostics.F90
A       schemes/sima_diagnostics/convective_cloud_cover_diagnostics.meta
  - cldfrc diagnostic schemes,
  - including split out shallow/deep convective cloud cover in convective_cloud_cover scheme

A       schemes/sima_diagnostics/cloud_particle_sedimentation_diagnostics.F90
A       schemes/sima_diagnostics/cloud_particle_sedimentation_diagnostics.meta
A       schemes/sima_diagnostics/rk_stratiform_diagnostics.F90
A       schemes/sima_diagnostics/rk_stratiform_diagnostics.meta
  - RK diagnostic schemes

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       schemes/cloud_fraction/compute_cloud_fraction.meta
M       schemes/cloud_fraction/convective_cloud_cover.meta
M       schemes/hack_shallow/hack_convect_shallow.meta
M       schemes/rasch_kristjansson/cloud_particle_sedimentation.F90
M       schemes/rasch_kristjansson/cloud_particle_sedimentation.meta
M       schemes/rasch_kristjansson/prognostic_cloud_water.F90
M       schemes/rasch_kristjansson/prognostic_cloud_water.meta
M       schemes/rasch_kristjansson/rk_stratiform.meta
  - update with assigned standard names
  - minor cleanup of unused variables

List all automated tests that failed, as well as an explanation for why they weren't fixed:
N/A

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
N/A - SIMA diagnostics only

If yes to the above question, describe how this code was validated with the new/modified features:
N/A

[jimmielin]

Note to self that once ESCOMP/CAM#1296 (review) is merged the magic numbers here for iwc/lwc also need to be updated to use physconst::rair

Completed in 2639a45

[nusbaume]

Looks good @jimmielin! I did have some questions and suggestions, but hopefully nothing that will be too difficult to resolve (although if that is not the case please let me know). Thanks!

[nusbaume]

Is there a reason SNOWSED has a different long name compare to the PRECSED and RAINSED variables? For example I imagine one could do the following instead to better match the other two fields:

stratiform_lwe_cloud_ice_surface_flux_due_to_sedimentation

But maybe there is a reason to keep the long name as-is?

[jimmielin]

Thanks for the question! SNOWSED had a previously-assigned standard name from pbuf_SNOW_SED so it looks different than the others maybe due to the passage of time. So maybe it can be updated to be up to the more recent guidelines / consistency with the current standard names?

[nusbaume]

Thanks for the explanation @jimmielin! Given that SNOWSED appears to be the exact same physical quantity as PRECSED but just for ice I might vote to give the name I specified above. Of course if this is going to involve additional work elsewhere (e.g. in other physics schemes) then feel free to just make an issue for it and we can deal with it later. Thanks!

[jimmielin]

Thanks @nusbaume, updated to stratiform_lwe_cloud_ice_surface_flux_due_to_sedimentation!

[nusbaume]

Looks great to me now! I did leave one comment unresolved with regards to the SNOWSED variable but I am happy to just make an issue for it and deal with it later if that is easiest.