Updating contributors, correcting links, and adding soso tool to readme#279
Updating contributors, correcting links, and adding soso tool to readme#279iannesbitt wants to merge 3 commits intodevelopfrom
Conversation
|
@clnsmth I guess we only need reviews to merge to |
clnsmth
left a comment
clnsmth
left a comment
There was a problem hiding this comment.
Hey @iannesbitt, thanks for putting this together. I have one requested change, but otherwise it looks good to me.
| <td align="center"><a href="https://github.com/mathiasbockwoldt"><img src="https://avatars.githubusercontent.com/u/8100468?v=4?s=50" width="50px;" alt=""/><br /><sub><b>Mathias Bockwoldt</b></sub></a><br /><a href="#ideas-mathiasbockwoldt" title="Ideas, Planning, & Feedback">🤔</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"><a href="https://github.com/clnsmth"><img src="https://avatars.githubusercontent.com/u/25492069?v=4?s=50" width="50px;" alt=""/><br /><sub><b>Colin Smith</b></sub></a><br /><a href="#design-clnsmth" title="Design">🎨</a> <a href="https://github.com/ESIPFed/science-on-schema.org/commits?author=clnsmth" title="Code">💻</a> <a href="#content-clnsmth" title="Content">🖋</a> <a href="https://github.com/ESIPFed/science-on-schema.org/commits?author=clnsmth" title="Documentation">📖</a> <a href="#eventOrganizing-clnsmth" title="Event Organizing">📋</a> <a href="#ideas-clnsmth" title="Ideas, Planning, & Feedback">🤔</a> <a href="#maintenance-clnsmth" title="Maintenance">🚧</a></td> |
There was a problem hiding this comment.
@iannesbitt, while I'm flattered by the recognition, I'm a little uneasy with the roles attributed to my contributions. Would you mind trimming out Design, Content, and Documentation?
There was a problem hiding this comment.
btw, those roles are all managed through the all-contributors config file: https://github.com/ESIPFed/science-on-schema.org/blob/main/.all-contributorsrc
They should not be edited directly in the HTML. Rather, run the all-contributors generator. It's been a while, but I can track that down if you can't find it.
There was a problem hiding this comment.
Client tool (and looks like there is a GH action now too): https://www.npmjs.com/package/all-contributors-cli
There was a problem hiding this comment.
Sorry Colin I will fix that shortly. Also, I totally missed the tool so thank you for pointing that out.
There was a problem hiding this comment.
Hey @iannesbitt. Just checking in to see if you've had a chance to address the comment from @mbjones. I want to make sure you're not waiting on me.
There was a problem hiding this comment.
I couldn't get all-contributors-cli installed in my environment due to package conflicts and I've been dealing with some end-of-grant work for another project this week, so I haven't had a chance yet. I will revisit early next week, sorry for the delay.
There was a problem hiding this comment.
@iannesbitt Maybe we can skip updating the contributors for now to unblock the fix to the meeting link and soso tool listing?
There was a problem hiding this comment.
Yep, thanks for the ping. That's a good idea.
3 participants
No description provided.